Add workflow for SQL CLI integration tests #4770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Swiddis
added
the
infrastructure
ps48
reviewed
Nov 11, 2025
Comment on lines
9
to
32
| - 'api/**' | ||
| - 'sql/**' | ||
| - 'ppl/**' | ||
| - 'core/**' | ||
| - 'opensearch/**' | ||
| - 'common/**' | ||
| - 'protocol/**' | ||
| - '**/*.gradle' | ||
| - '.github/workflows/sql-cli-integration-test.yml' | ||
| push: | ||
| branches: | ||
| - main | ||
| - '[0-9]+.[0-9]+' | ||
| - '[0-9]+.x' | ||
| paths: | ||
| - 'api/**' | ||
| - 'sql/**' | ||
| - 'ppl/**' | ||
| - 'core/**' | ||
| - 'opensearch/**' | ||
| - 'common/**' | ||
| - 'protocol/**' | ||
| - '**/*.gradle' | ||
| - '.github/workflows/sql-cli-integration-test.yml' |
Member
There was a problem hiding this comment.
Just curious why do we need these paths, why shouldn't we run this for all updates (except docs)? can path-ignore be shorter here ?
Collaborator
Author
There was a problem hiding this comment.
Just nice to have if we only match what we need, I updated these to match what we have for sql-test-and-build-workflow instead.
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Collaborator
Author
|
CLI tests passed |
Swiddis
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
qianheng-aws,
seankao-az,
vamsimanohar,
ykmr1224 and
yuancu
as code owners
Contributor
|
This PR is stalled because it has been open for 2 weeks with no activity. |
RyanL1997
approved these changes
Dec 8, 2025
dai-chen
reviewed
Dec 8, 2025
Collaborator
Author
|
e.g. the forceCleanup method being added to RestClient's interface: https://github.com/opensearch-project/sql-cli/pull/39/files#diff-2536e76d9e0730c06e4fd3954ee536137427d864e87357d9bf722c92740306b6R324 |
penghuo
approved these changes
Dec 9, 2025
Member
|
CI is broken after this PR merged @Swiddis |
asifabashar
pushed a commit
to asifabashar/sql
that referenced
this pull request
Dec 10, 2025
* Add workflow for SQL CLI integration tests Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Switch SQL checkout path for CLI Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Tweak paths and mkdir for remote Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix filename Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove redundant verification Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Don't pull after clone Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> Signed-off-by: Asif Bashar <asif.bashar@gmail.com>
asifabashar
pushed a commit
to asifabashar/sql
that referenced
this pull request
Dec 10, 2025
* Add workflow for SQL CLI integration tests Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Switch SQL checkout path for CLI Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Tweak paths and mkdir for remote Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix filename Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove redundant verification Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Don't pull after clone Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> Signed-off-by: Asif Bashar <asif.bashar@gmail.com>
asifabashar
pushed a commit
to asifabashar/sql
that referenced
this pull request
Dec 10, 2025
* Add workflow for SQL CLI integration tests Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Switch SQL checkout path for CLI Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Tweak paths and mkdir for remote Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix filename Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove redundant verification Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Don't pull after clone Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Companion to opensearch-project/sql-cli#42: Runs some tests & checks against basic compilation breakage for the SQL CLI.
The CLI tests aren't very robust. For better testing, I understand the plan is to wait for the PPL unification that @dai-chen is working on and write a suite around it.
At some point I'll need to make the
_shard_docchanges configurable and start testing on a compatibility matrix, but this at least should keep the live branches of each repo in sync for now.Related Issues
N/A
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.