Skip to content

Conversation

@PauiC
Copy link

@PauiC PauiC commented Sep 22, 2025

Description

This feature provides intelligent summarization when ML Commons Chat Agents and PER (planner) agent reach their maximum iteration limit without completing tasks.

Key Components:

Trigger Mechanism: Activates when agent execution reaches the max_iteration parameter limit

Related Issues

#4150

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@PauiC PauiC temporarily deployed to ml-commons-cicd-env-require-approval September 22, 2025 07:11 — with GitHub Actions Inactive
@PauiC PauiC temporarily deployed to ml-commons-cicd-env-require-approval September 22, 2025 07:11 — with GitHub Actions Inactive
@PauiC PauiC temporarily deployed to ml-commons-cicd-env-require-approval September 22, 2025 07:11 — with GitHub Actions Inactive
@PauiC PauiC temporarily deployed to ml-commons-cicd-env-require-approval September 22, 2025 07:11 — with GitHub Actions Inactive
@PauiC
Copy link
Author

PauiC commented Sep 22, 2025

Here is an example
image

@xinyual
Copy link
Collaborator

xinyual commented Sep 22, 2025

Do we plan to summarize the memory when it's too long?

@PauiC
Copy link
Author

PauiC commented Sep 22, 2025

Do we plan to summarize the memory when it's too long?

As far as I know, there’s no such plan.

@codecov
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

❌ Patch coverage is 64.28571% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.01%. Comparing base (7bf4b54) to head (51dbde8).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../ml/engine/algorithms/agent/MLChatAgentRunner.java 64.28% 10 Missing and 10 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4184      +/-   ##
============================================
- Coverage     82.02%   82.01%   -0.01%     
- Complexity     9195     9206      +11     
============================================
  Files           789      789              
  Lines         39541    39597      +56     
  Branches       4387     4396       +9     
============================================
+ Hits          32432    32475      +43     
- Misses         5219     5224       +5     
- Partials       1890     1898       +8     
Flag Coverage Δ
ml-commons 82.01% <64.28%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PauiC PauiC had a problem deploying to ml-commons-cicd-env-require-approval September 22, 2025 23:10 — with GitHub Actions Failure
@PauiC PauiC had a problem deploying to ml-commons-cicd-env-require-approval September 22, 2025 23:10 — with GitHub Actions Failure
@PauiC PauiC had a problem deploying to ml-commons-cicd-env-require-approval September 23, 2025 02:15 — with GitHub Actions Failure
@PauiC PauiC had a problem deploying to ml-commons-cicd-env-require-approval September 23, 2025 02:15 — with GitHub Actions Failure
@PauiC PauiC had a problem deploying to ml-commons-cicd-env-require-approval September 23, 2025 02:15 — with GitHub Actions Failure
@PauiC PauiC had a problem deploying to ml-commons-cicd-env-require-approval September 23, 2025 02:15 — with GitHub Actions Failure
@Hailong-am
Copy link
Contributor

Hailong-am commented Sep 23, 2025

@pyek-bot @mingshl would you mind to take a look at this PR?

PauiC added 11 commits November 18, 2025 11:24
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
@PauiC PauiC requested a deployment to ml-commons-cicd-env-require-approval November 18, 2025 03:26 — with GitHub Actions Waiting
@PauiC PauiC requested a deployment to ml-commons-cicd-env-require-approval November 18, 2025 03:26 — with GitHub Actions Waiting
@PauiC PauiC requested a deployment to ml-commons-cicd-env-require-approval November 18, 2025 03:26 — with GitHub Actions Waiting
@PauiC PauiC requested a deployment to ml-commons-cicd-env-require-approval November 18, 2025 03:26 — with GitHub Actions Waiting
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
@PauiC PauiC had a problem deploying to ml-commons-cicd-env-require-approval November 18, 2025 05:02 — with GitHub Actions Error
@PauiC PauiC had a problem deploying to ml-commons-cicd-env-require-approval November 18, 2025 05:02 — with GitHub Actions Failure
@PauiC PauiC had a problem deploying to ml-commons-cicd-env-require-approval November 18, 2025 05:02 — with GitHub Actions Failure
@PauiC PauiC had a problem deploying to ml-commons-cicd-env-require-approval November 18, 2025 05:02 — with GitHub Actions Error
@PauiC
Copy link
Author

PauiC commented Nov 18, 2025

image image

@PauiC
Copy link
Author

PauiC commented Nov 18, 2025

Here is the result of ./gradlew build
image

@PauiC
Copy link
Author

PauiC commented Nov 18, 2025

I found that the test failed. However, I’ve checked this test carefully and found I haven’t modified the test itself or its related code. Would you like me to adjust the test to make it pass?
image

@PauiC PauiC had a problem deploying to ml-commons-cicd-env-require-approval November 18, 2025 20:51 — with GitHub Actions Error
@PauiC PauiC had a problem deploying to ml-commons-cicd-env-require-approval November 18, 2025 20:51 — with GitHub Actions Failure
@PauiC PauiC had a problem deploying to ml-commons-cicd-env-require-approval November 18, 2025 20:51 — with GitHub Actions Failure
@PauiC PauiC had a problem deploying to ml-commons-cicd-env-require-approval November 18, 2025 20:51 — with GitHub Actions Error
@pyek-bot
Copy link
Collaborator

@PauiC These are flaky tests, let me ask the maintainers to trigger the CI again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants