Convert Guava Predicates.instanceOf
#919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trye to fix issue openrewrite#918, but without success.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/main/java/org/openrewrite/java/migrate/guava/NoGuavaPredicatesInstanceOf.java
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/migrate/guava/NoGuavaPredicatesInstanceOfTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
src/main/java/org/openrewrite/java/migrate/guava/NoGuavaPredicatesInstanceOf.java
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
src/main/java/org/openrewrite/java/migrate/guava/NoGuavaPredicatesInstanceOf.java
Outdated
Show resolved
Hide resolved
timtebeek
changed the title
Predicates.instanceOfPredicates.instanceOf
timtebeek
approved these changes
Nov 12, 2025
Member
timtebeek
left a comment
timtebeek
left a comment
There was a problem hiding this comment.
Thanks again! We'll merge this as is with the missing type information, as I don't expect a lot of downstream recipes to be affected as they are unlikely to edit in the same position.
We can separately look at adding support for method references to JavaTemplate.
github-project-automation
bot
moved this from In Progress
to Ready to Review
in OpenRewrite
mergify bot
added a commit
to robfrank/linklift
that referenced
this pull request
Nov 16, 2025
…21.1 to 3.21.2 [skip ci] Bumps [org.openrewrite.recipe:rewrite-migrate-java](https://github.com/openrewrite/rewrite-migrate-java) from 3.21.1 to 3.21.2. Release notes *Sourced from [org.openrewrite.recipe:rewrite-migrate-java's releases](https://github.com/openrewrite/rewrite-migrate-java/releases).* > v3.21.2 > ------- > > What's Changed > -------------- > > * JaxB plugin migrations from 2.X to 4.0 by [`@MBoegers`](https://github.com/MBoegers) in [openrewrite/rewrite-migrate-java#932](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/932) > * `jaxws-maven-plugin` to 2.3.X by [`@MBoegers`](https://github.com/MBoegers) in [openrewrite/rewrite-migrate-java#929](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/929) > * Update jakarta-ee-10.yml add tyrus to ee10 by [`@ChenyuWang98`](https://github.com/ChenyuWang98) in [openrewrite/rewrite-migrate-java#935](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/935) > * Always add explicit type to the `Predicate.isEqual` method by [`@lredor`](https://github.com/lredor) in [openrewrite/rewrite-migrate-java#927](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/927) > * Convert Guava `Predicates.instanceOf` by [`@lredor`](https://github.com/lredor) in [openrewrite/rewrite-migrate-java#919](https://redirect.github.com/openrewrite/rewrite-migrate-java/pull/919) > * Add the generated Guava recipes, as third-party requires Java 17 by [`@timtebeek`](https://github.com/timtebeek) in f02a15f59c08ab15bbde59ef413a16f4ec0653e8 > > **Full Changelog**: <openrewrite/rewrite-migrate-java@v3.21.1...v3.21.2> Commits * [`187bcbe`](openrewrite/rewrite-migrate-java@187bcbe) Convert Guava `Predicates.instanceOf` ([#919](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/919)) * [`f9c0ad4`](openrewrite/rewrite-migrate-java@f9c0ad4) Always add explicit type to the `Predicate.isEqual` method ([#927](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/927)) * [`8f8a2f5`](openrewrite/rewrite-migrate-java@8f8a2f5) Update jakarta-ee-10.yml add tyrus ([#935](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/935)) * [`afd0245`](openrewrite/rewrite-migrate-java@afd0245) Require a public no args constructor * [`521a2f3`](openrewrite/rewrite-migrate-java@521a2f3) OpenRewrite recipe best practices * [`341b4c0`](openrewrite/rewrite-migrate-java@341b4c0) [Auto] SDKMAN! Java candidates as of 2025-11-10T1018 * [`f02a15f`](openrewrite/rewrite-migrate-java@f02a15f) Add the generated Guava recipes, as third-party requires Java 17 * [`b7c506a`](openrewrite/rewrite-migrate-java@b7c506a) `jaxws-maven-plugin` to 2.3.X ([#929](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/929)) * [`ee64233`](openrewrite/rewrite-migrate-java@ee64233) JaxB plugin migrations from 2.X to 4.0 ([#932](https://redirect.github.com/openrewrite/rewrite-migrate-java/issues/932)) * See full diff in [compare view](openrewrite/rewrite-migrate-java@v3.21.1...v3.21.2) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anything in particular you'd like reviewers to focus on?
This PR is only a DRAFT. I have not succeeded to do the conversion.
Checklist