feat: scheduler robustness #210
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diaphteiros
requested review from
ValentinGerlach,
maximiliantech and
robertgraeff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Increases robustness of the scheduler (
ClusterRequestresources) against loss ofClusterresources. See release notes for details.Which issue(s) this PR fixes:
Needs to be verified, but it should solve openmcp-project/backlog#300.
Special notes for your reviewer:
Release note:
Unless explicitly requested via the `clusters.openmcp.cloud/randomize-cluster-name: "true"` label, the names of `Cluster` resources created for `ClusterRequest`s are now deterministic (using a hash of name and namespace of the request) instead of random. This makes it easier to recover lost `Cluster` resources. Note that for limitedly shared clusters, the name depends on the `ClusterRequest` that initially created the `Cluster` and might still change when the `Cluster` is lost and later re-created by the scheduler.