Skip to content

Fix cluster name parsing logic #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix cluster name parsing logic #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions internal/controller/managedmetric_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import (
"context"
"fmt"
"net/url"
"strings"
"time"

apierrors "k8s.io/apimachinery/pkg/api/errors"
Expand Down Expand Up @@ -309,11 +308,7 @@ func getClusterInfo(config *rest.Config) (string, error) {
return "localhost", nil
}

// Remove any prefix (like "kubernetes" or "kubernetes.default.svc")
parts := strings.Split(hostname, ".")
clusterName := parts[0]

return clusterName, nil
return hostname, nil
}

// OrchestratorFactory is a function type for creating orchestrators
Expand Down
8 changes: 4 additions & 4 deletions internal/controller/metric_controller_helpers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,22 +45,22 @@ func TestGetClusterInfo(t *testing.T) {
{
name: "KubernetesService",
host: "https://kubernetes.default.svc:6443",
expectedName: "kubernetes",
expectedName: "kubernetes.default.svc",
},
{
name: "CustomClusterName",
host: "https://my-cluster-api.example.com:6443",
expectedName: "my-cluster-api",
expectedName: "my-cluster-api.example.com",
},
{
name: "IPAddress",
host: "https://192.168.1.1:6443",
expectedName: "192", // The function only extracts the first part of the IP address
expectedName: "192.168.1.1", // The function only extracts the first part of the IP address
Copy link
Member

@maximiliantech maximiliantech Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment here is a bit misleading since the whole IP address is now expected. Can you remove the comment please?

},
{
name: "WithPath",
host: "https://kubernetes.default.svc:6443/api",
expectedName: "kubernetes",
expectedName: "kubernetes.default.svc",
},
}

Expand Down