Skip to content

Conversation

@fandreuz
Copy link
Contributor

@fandreuz fandreuz commented Nov 27, 2025

This PR contains a clean backport of JDK-8359472.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8359472 needs maintainer approval

Issue

  • JDK-8359472: JVM crashes when attaching a dynamic agent before JVMTI_PHASE_LIVE (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2489/head:pull/2489
$ git checkout pull/2489

Update a local copy of the PR:
$ git checkout pull/2489
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2489/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2489

View PR using the GUI difftool:
$ git pr show -t 2489

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2489.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 27, 2025

👋 Welcome back fandreuzzi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 27, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 2a8cbd944ba4d8896e48181e396c65f70e5aa215 8359472: JVM crashes when attaching a dynamic agent before JVMTI_PHASE_LIVE Nov 27, 2025
@openjdk
Copy link

openjdk bot commented Nov 27, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 27, 2025
@openjdk
Copy link

openjdk bot commented Nov 27, 2025

⚠️ @fandreuz This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 27, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 27, 2025

Webrevs

@fandreuz
Copy link
Contributor Author

/approval request Fixes a crash happening when an agent tries to load before live phase. The fix is simple and tests are attached to verify all use cases. Passes tier1.

@openjdk
Copy link

openjdk bot commented Nov 27, 2025

@fandreuz
8359472: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant