8283544: HttpClient GET method adds Content-Length: 0 header #4162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I backport this for parity with 17.0.18-oracle.
Clean backport. Original change is in 19.
The test needed a small adaption to build, see extra commit.
HEAD() was only added by https://bugs.openjdk.org/browse/JDK-8276559 (httpclient) Consider adding an HttpRequest.Builder.HEAD method to build a HEAD request.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4162/head:pull/4162$ git checkout pull/4162Update a local copy of the PR:
$ git checkout pull/4162$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4162/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4162View PR using the GUI difftool:
$ git pr show -t 4162Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4162.diff