8371450: AES performance improvements for key schedule generation

[smemery]

This fix improves performance in the AES key schedule generation by eliminating an unnecessary object and unnecessary mask in the inverse key schedule.

The micro:org.openjdk.bench.javax.crypto.AESReinit benchmark results are improved by 6.96% for arm64 and 7.79% for x86_64.

Thank you @jnimeh for catching the unnecessary byte mask!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8371450: AES performance improvements for key schedule generation (Enhancement - P4)

Reviewers

• Jamil Nimeh (@jnimeh - Reviewer) Review applies to 0e9d14f9
• Valerie Peng (@valeriepeng - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28188/head:pull/28188
$ git checkout pull/28188

Update a local copy of the PR:
$ git checkout pull/28188
$ git pull https://git.openjdk.org/jdk.git pull/28188/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28188

View PR using the GUI difftool:
$ git pr show -t 28188

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28188.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back smemery! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@smemery This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371450: AES performance improvements for key schedule generation

Reviewed-by: valeriep, jnimeh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 73 new commits pushed to the master branch:

• 279f39f: 8371681: Remove unused VMOp type CollectForCodeCacheAllocation
• 42aecc4: 8371680: JVMTI: Remove unused VMOp type JvmtiPostObjectFree
• d91480b: 8371675: ZGC: Remove leftover X VMOp symbols
• ... and 70 more: https://git.openjdk.org/jdk/compare/8796611206438c6fe8bf0cba87dca089d9da2e30...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jnimeh, @valeriepeng) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@smemery The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 04: Full - Incremental (2718a125)
• 03: Full - Incremental (fc2d1662)
• 02: Full - Incremental (55e052f6)
• 01: Full - Incremental (0e9d14f9)
• 00: Full (c462a58e)

[smemery]

/integrate

[openjdk]

@smemery This pull request has not yet been marked as ready for integration.

[smemery]

/integrate

[openjdk]

@smemery
Your change (at version 2718a12) is now ready to be sponsored by a Committer.

[jnimeh]

/sponsor

[openjdk]

Going to push as commit 436b335.
Since your change was applied there have been 73 commits pushed to the master branch:

• 279f39f: 8371681: Remove unused VMOp type CollectForCodeCacheAllocation
• 42aecc4: 8371680: JVMTI: Remove unused VMOp type JvmtiPostObjectFree
• d91480b: 8371675: ZGC: Remove leftover X VMOp symbols
• ... and 70 more: https://git.openjdk.org/jdk/compare/8796611206438c6fe8bf0cba87dca089d9da2e30...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jnimeh @smemery Pushed as commit 436b335.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.