fix: explicitly use remote addr for unicast UDP queries #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This could indeed break things on the socket communication. I need to double check it and test it on my own in all scenarios, where unicast and broadcast communication is going on. Still suprised me like mentioned in #51 that this behavior change in Windows. My week is now stuffed sadly, so I need some time to verify that. |
Contributor
|
I'm currently Testing some games. The good news: Broadcasts Games like Renegade X are still working. I need to test UT3 and Source games too and then I can give an opinion about this. Next step would be to test Windows. We'll see it. I'll update you ASAP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #51 by passing
remote_addr=toloop.create_datagram_endpoint()insideUdpClient.communicate(), omitting thelocal_addr=argument for protocols that don't specify a source port or allow broadcasting.This PR may have side effects that I don't know about, since I don't often use the low-level asyncio APIs or sockets in general.