-
Notifications
You must be signed in to change notification settings - Fork 124
RHAIENG-2042: chore(base-images): add ppc64le (and s390x todo later) architectures to odh-base-image-cpu-py312-c9s
#2688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdated two Tekton PipelineRun YAML files: Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Well, not a huge problem; we can start from centos image and install python ourselves, by simply stealing from either sclorg or aipcc. Either way, it's maybe for the best, because that way we can only install what AIPCC preinstalls and nothing extra. That's good for fast(er) feedback for RHDS work. |
…se-image-cpu-py312-c9s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.tekton/odh-base-image-cpu-py312-c9s-pull-request.yaml (1)
42-43: Clarify the s390x enablement TODO.The TODO comment references enabling s390x "once it is supported in the base image," but based on the PR discussion, the blocker is more specific:
quay.io/sclorg/python-312-c9s:c9sdoes not provide an s390x variant. Consider clarifying the TODO to either reference the specific blocker or the workaround approach (starting from CentOS and installing Python manually), so future work has clear direction.Example clarification:
- # TODO(jdanek): Enable s390x once it is supported in the base image. + # TODO(jdanek): Enable s390x (blocker: quay.io/sclorg/python-312-c9s:c9s lacks s390x variant; workaround: use CentOS base + manual Python install).
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.tekton/odh-base-image-cpu-py312-c9s-pull-request.yaml(1 hunks).tekton/odh-base-image-cpu-py312-c9s-push.yaml(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- .tekton/odh-base-image-cpu-py312-c9s-push.yaml
🔇 Additional comments (1)
.tekton/odh-base-image-cpu-py312-c9s-pull-request.yaml (1)
37-43: Build-platforms configuration is consistent across both pipeline files.Verification confirms that
.tekton/odh-base-image-cpu-py312-c9s-pull-request.yamland.tekton/odh-base-image-cpu-py312-c9s-push.yamlhave identicalbuild-platformsconfigurations. Both enablelinux/x86_64,linux/arm64, andlinux/ppc64le, withlinux/s390xdeferred in both files using the same TODO rationale. No inconsistencies detected.
ppc64le and s390x architectures to odh-base-image-cpu-py312-c9sppc64le and s390x architectures to odh-base-image-cpu-py312-c9s
ppc64le and s390x architectures to odh-base-image-cpu-py312-c9sppc64le (and s390x todo later) architectures to odh-base-image-cpu-py312-c9s
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ide-developer The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jiridanek: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
https://issues.redhat.com/browse/RHAIENG-2042
Description
Enablement work for
How Has This Been Tested?
Self checklist (all need to be checked):
make test(gmakeon macOS) before asking for reviewDockerfile.konfluxfiles should be done inodh/notebooksand automatically synced torhds/notebooks. For Konflux-specific changes, modifyDockerfile.konfluxfiles directly inrhds/notebooksas these require special attention in the downstream repository and flow to the upcoming RHOAI release.Merge criteria:
Summary by CodeRabbit