Skip to content

Conversation

@jiridanek
Copy link
Member

@jiridanek jiridanek commented Nov 19, 2025

https://issues.redhat.com/browse/RHAIENG-2042

Description

Enablement work for

How Has This Been Tested?

Self checklist (all need to be checked):

  • Ensure that you have run make test (gmake on macOS) before asking for review
  • Changes to everything except Dockerfile.konflux files should be done in odh/notebooks and automatically synced to rhds/notebooks. For Konflux-specific changes, modify Dockerfile.konflux files directly in rhds/notebooks as these require special attention in the downstream repository and flow to the upcoming RHOAI release.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Summary by CodeRabbit

  • Chores
    • Added PowerPC 64-bit (ppc64le) to the build platforms, expanding multi-architecture build coverage alongside x86_64 and ARM64.
    • Support for s390x remains pending (commented/out and marked TODO); not yet enabled.

@openshift-ci openshift-ci bot requested review from atheo89 and daniellutz November 19, 2025 12:39
@github-actions github-actions bot added the review-requested GitHub Bot creates notification on #pr-review-ai-ide-team slack channel label Nov 19, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 19, 2025

Walkthrough

Updated two Tekton PipelineRun YAML files: linux/ppc64le was added to the build-platforms parameter; linux/s390x remains commented out with a TODO in both files.

Changes

Cohort / File(s) Change Summary
Tekton PipelineRun platform list
.tekton/odh-base-image-cpu-py312-c9s-pull-request.yaml, .tekton/odh-base-image-cpu-py312-c9s-push.yaml
Added linux/ppc64le to the build-platforms parameter value. linux/s390x remains commented out with a TODO; no other fields changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify platform strings formatting (linux/ppc64le) and consistency across both files.
  • Confirm linux/s390x is intentionally left commented and note the TODO.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description includes a reference to a related issue and PR, has the self-checklist partially completed (2/2 items checked), and partially addresses the merge criteria (2/3 items checked). The 'How Has This Been Tested?' section is incomplete with only a template comment and no actual testing details provided. Complete the 'How Has This Been Tested?' section with specific testing details, environment information, and actual test results. Additionally, fill in the unchecked 'Testing instructions have been added' merge criterion item or provide explanation for why it doesn't apply.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title clearly and concisely describes the main change: adding ppc64le architecture support to odh-base-image-cpu-py312-c9s, with s390x marked as a future todo.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jiridanek
Copy link
Member Author

Error: unable to copy from source docker://quay.io/sclorg/python-312-c9s:c9s: choosing an image from manifest list docker://quay.io/sclorg/python-312-c9s:c9s: no image found in manifest list for architecture "s390x", variant "", OS "linux"

Well, not a huge problem; we can start from centos image and install python ourselves, by simply stealing from either sclorg or aipcc. Either way, it's maybe for the best, because that way we can only install what AIPCC preinstalls and nothing extra. That's good for fast(er) feedback for RHDS work.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.tekton/odh-base-image-cpu-py312-c9s-pull-request.yaml (1)

42-43: Clarify the s390x enablement TODO.

The TODO comment references enabling s390x "once it is supported in the base image," but based on the PR discussion, the blocker is more specific: quay.io/sclorg/python-312-c9s:c9s does not provide an s390x variant. Consider clarifying the TODO to either reference the specific blocker or the workaround approach (starting from CentOS and installing Python manually), so future work has clear direction.

Example clarification:

-    # TODO(jdanek): Enable s390x once it is supported in the base image.
+    # TODO(jdanek): Enable s390x (blocker: quay.io/sclorg/python-312-c9s:c9s lacks s390x variant; workaround: use CentOS base + manual Python install).
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8a4ff60 and 0ee4f44.

📒 Files selected for processing (2)
  • .tekton/odh-base-image-cpu-py312-c9s-pull-request.yaml (1 hunks)
  • .tekton/odh-base-image-cpu-py312-c9s-push.yaml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .tekton/odh-base-image-cpu-py312-c9s-push.yaml
🔇 Additional comments (1)
.tekton/odh-base-image-cpu-py312-c9s-pull-request.yaml (1)

37-43: Build-platforms configuration is consistent across both pipeline files.

Verification confirms that .tekton/odh-base-image-cpu-py312-c9s-pull-request.yaml and .tekton/odh-base-image-cpu-py312-c9s-push.yaml have identical build-platforms configurations. Both enable linux/x86_64, linux/arm64, and linux/ppc64le, with linux/s390x deferred in both files using the same TODO rationale. No inconsistencies detected.

@jiridanek jiridanek changed the title chore(base-images): add ppc64le and s390x architectures to odh-base-image-cpu-py312-c9s RHAIENG-2042: chore(base-images): add ppc64le and s390x architectures to odh-base-image-cpu-py312-c9s Nov 19, 2025
@openshift-ci openshift-ci bot added size/xs and removed size/xs labels Nov 19, 2025
@jiridanek jiridanek changed the title RHAIENG-2042: chore(base-images): add ppc64le and s390x architectures to odh-base-image-cpu-py312-c9s RHAIENG-2042: chore(base-images): add ppc64le (and s390x todo later) architectures to odh-base-image-cpu-py312-c9s Nov 19, 2025
@openshift-ci openshift-ci bot added size/xs and removed size/xs labels Nov 19, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ide-developer
Once this PR has been reviewed and has the lgtm label, please assign jesuino for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2025

@jiridanek: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 0ee4f44 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jiridanek jiridanek merged commit 374eed5 into opendatahub-io:main Nov 19, 2025
14 of 16 checks passed
@jiridanek jiridanek deleted the jd_arches branch November 19, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm review-requested GitHub Bot creates notification on #pr-review-ai-ide-team slack channel size/xs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants