RHOAIENG-38634: sync(rstudio): comment out R packages installation same as we do in rhds/notebooks

[jiridanek]

https://issues.redhat.com/browse/RHOAIENG-38634

Description

rstudio minimal image should not install this many packages

cherry-picked from

• Sync rhds:main from odh:main red-hat-data-services/notebooks#1624

How Has This Been Tested?

Self checklist (all need to be checked):

• Ensure that you have run make test (gmake on macOS) before asking for review
• Changes to everything except Dockerfile.konflux files should be done in odh/notebooks and automatically synced to rhds/notebooks. For Konflux-specific changes, modify Dockerfile.konflux files directly in rhds/notebooks as these require special attention in the downstream repository and flow to the upcoming RHOAI release.

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

Summary by CodeRabbit

• Chores
  • Disabled R package installation during RStudio RHEL 9 Python 3.12 image builds (CPU and CUDA variants). The original installation steps are preserved as comments for reference. As a result, R packages will no longer be installed during the image build process, affecting the contents of the produced images and reducing build-time package execution.

[coderabbitai]

Walkthrough

Two RStudio Dockerfiles had their R package installation blocks disabled by commenting out the steps that copy and run install_packages.R in both CPU and CUDA variants; no other build steps were changed.

Changes

Cohort / File(s)	Summary
R package installation disabled rstudio/rhel9-python-3.12/Dockerfile.cpu, rstudio/rhel9-python-3.12/Dockerfile.cuda	The lines that copy install_packages.R, run it via R, and remove it were commented out in both Dockerfiles, preventing R package installation during image build while preserving the original commands as comments.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Both edits are identical pattern changes (commenting out existing commands).
• Check for leftover heredoc or partial commands, and confirm no stray artifacts (unclosed blocks or unintended syntax) that could affect Dockerfile parsing.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: commenting out R package installation in RStudio Dockerfiles to align with rhds/notebooks approach.
Description check	✅ Passed	The PR description includes the issue reference, clear rationale, testing confirmation, and addresses self-checklist items. However, testing instructions for the changes are not explicitly documented, and manual verification claim cannot be independently verified.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6ee7f55 and 34a95e2.

📒 Files selected for processing (2)

• rstudio/rhel9-python-3.12/Dockerfile.cpu (1 hunks)
• rstudio/rhel9-python-3.12/Dockerfile.cuda (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

• GitHub Check: Red Hat Konflux / odh-workbench-rstudio-minimal-cuda-py312-rhel9-on-pull-request
• GitHub Check: Red Hat Konflux / odh-workbench-rstudio-minimal-cpu-py312-rhel9-on-pull-request
• GitHub Check: build (rstudio-rhel9-python-3.12, 3.12, linux/amd64, true) / build
• GitHub Check: build (cuda-rstudio-rhel9-python-3.12, 3.12, linux/amd64, true) / build
• GitHub Check: code-static-analysis

🔇 Additional comments (2)

rstudio/rhel9-python-3.12/Dockerfile.cpu (1)

170-177: Changes correctly disable R package installation.

The commented-out block is properly formatted and allows straightforward re-enablement if needed. Confirm that install_packages.R should remain in the repository even though it's no longer executed during the build.

rstudio/rhel9-python-3.12/Dockerfile.cuda (1)

184-191: Consistency maintained: CUDA variant mirrors CPU changes.

The commented-out R package installation block is identical to the CPU variant, ensuring consistent behavior across image builds. This aligns with the stated goal of matching behavior in rhds/notebooks.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

rstudio/rhel9-python-3.12/Dockerfile.cuda (1)

175-182: Consistent R package installation disablement across variants.

The CUDA variant mirrors the CPU Dockerfile changes exactly, maintaining build consistency. Both CPU and CUDA images will now skip R package installation during build while retaining the R runtime.

Consider adding a note in repository documentation (e.g., README or a dedicated section) clarifying that users can manually install R packages post-deployment if needed, since this step has been disabled. This helps set expectations for users familiar with the previous behavior.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0697401 and 6ee7f55.

📒 Files selected for processing (2)

• rstudio/rhel9-python-3.12/Dockerfile.cpu (1 hunks)
• rstudio/rhel9-python-3.12/Dockerfile.cuda (1 hunks)

🔇 Additional comments (1)

rstudio/rhel9-python-3.12/Dockerfile.cpu (1)

161-168: R package installation correctly disabled and preserved.

The commented section cleanly preserves the original installation logic while effectively disabling it during build. This approach is consistent with the cherry-picked change from rhds/notebooks and allows straightforward re-enablement if needed in the future.

[ysok]

@jiridanek if these R packages shouldn't be installed, why were they here at the first place?

@atheo89 was asking me to turn them back on in this PR, they take lot of time to run.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ide-developer
Once this PR has been reviewed and has the lgtm label, please assign paulovmr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

New changes are detected. LGTM label has been removed.

[openshift-ci]

@jiridanek: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/images	34a95e2	link	true	/test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.