NO-JIRA: refactor(jupyter/minimal/Dockerfile.cpu): wrap multiple RUN commands with bash for improved readability and error handling

[jiridanek]

Carrying on with

• NO-JIRA: refactor(Dockerfile.cpu): wrap multiple RUN commands with bash for improved readability and error handling #2645
• NO-JIRA: refactor(jupyter/datascience/Dockerfile.cpu): wrap multiple RUN commands with bash for consistency, readability, and improved error handling #2647

Description

Reformat inline bash commands into HEREDOC blocks, so they can be later extracted to separate script files.

How Has This Been Tested?

Self checklist (all need to be checked):

• Ensure that you have run make test (gmake on macOS) before asking for review
• Changes to everything except Dockerfile.konflux files should be done in odh/notebooks and automatically synced to rhds/notebooks. For Konflux-specific changes, modify Dockerfile.konflux files directly in rhds/notebooks as these require special attention in the downstream repository and flow to the upcoming RHOAI release.

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

Summary by CodeRabbit

• Chores
  • Refactored Docker build process to improve error handling and build reliability through enhanced command sequencing.

[coderabbitai]

Walkthrough

The Dockerfile for jupyter/minimal/ubi9-python-3.12/Dockerfile.cpu was refactored to consolidate two separate RUN instructions into multi-line heredoc executions with bash strict error handling (set -Eeuxo pipefail), improving error semantics and command sequencing while preserving the same functional operations.

Changes

Cohort / File(s)

Summary

Dockerfile refactor to heredoc syntax jupyter/minimal/ubi9-python-3.12/Dockerfile.cpu

Replaced two single-line RUN instructions with multi-line heredoc blocks using /bin/bash, adding strict error handling via set -Eeuxo pipefail. Commands for OS package installation, cache cleanup, Python dependency setup, Jupyter configuration, kernel.json modification, config copying, permissions adjustment, and addon application are now executed within temporary embedded shell scripts instead of chained RUN lines.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Verify heredoc syntax correctness: Ensure the multi-line bash blocks are properly formatted and commands are not accidentally modified during translation.
• Error handling semantics: Confirm that set -Eeuxo pipefail does not introduce unexpected early termination or cause previously tolerated failures to now break the build.
• Docker layer implications: Review whether consolidating commands into a single layer affects build caching behavior as intended.
• Command preservation: Validate that all individual commands (package install, cache clean, pip install, kernel.json edits, etc.) are executed identically to the original configuration.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The description provides context and purpose but lacks critical testing details and has incomplete checklists; required sections are present but inadequately filled.	Fill in the 'How Has This Been Tested?' section with specific testing environment details and test execution results, and mark the self-checklist boxes to confirm pre-merge requirements were completed.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: refactoring to wrap RUN commands with bash HEREDOC blocks for improved readability and error handling.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ide-developer
Once this PR has been reviewed and has the lgtm label, please assign jesuino for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

jupyter/minimal/ubi9-python-3.12/Dockerfile.cpu (1)

97-114: Consolidation is functional and improves error handling; fix minor text quality issue.

The refactoring successfully wraps all setup steps into a single HEREDOC with strict bash error handling. All commands are bash-compatible and preserve the original functionality. However, line 99 contains a minor grammatical issue.

Apply this diff to fix the text:

-echo "Installing softwares and packages"
+echo "Installing software and packages"

This is an uncountable noun; "software" should not be pluralized.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7c7e9a7 and e9ebc01.

📒 Files selected for processing (1)

• jupyter/minimal/ubi9-python-3.12/Dockerfile.cpu (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)

• GitHub Check: build (cuda-jupyter-minimal-ubi9-python-3.12, 3.12, linux/arm64, false) / build
• GitHub Check: build (jupyter-minimal-ubi9-python-3.12, 3.12, linux/ppc64le, false) / build
• GitHub Check: build (cuda-jupyter-minimal-ubi9-python-3.12, 3.12, linux/amd64, false) / build
• GitHub Check: build (jupyter-minimal-ubi9-python-3.12, 3.12, linux/s390x, false) / build
• GitHub Check: build (jupyter-minimal-ubi9-python-3.12, 3.12, linux/amd64, false) / build
• GitHub Check: build (rocm-jupyter-minimal-ubi9-python-3.12, 3.12, linux/amd64, false) / build
• GitHub Check: Red Hat Konflux / odh-workbench-jupyter-minimal-rocm-py312-ubi9-on-pull-request
• GitHub Check: code-static-analysis

🔇 Additional comments (1)

jupyter/minimal/ubi9-python-3.12/Dockerfile.cpu (1)

37-42: Refactoring is consistent and follows established patterns in the file.

The HEREDOC structure with set -Eeuxo pipefail aligns with the existing pattern at lines 28–32 and 52–58. The addition of explicit cache cleanup (dnf clean all + rm -rf /var/cache/yum) is appropriate for minimizing layer size.

[openshift-ci]

@jiridanek: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/notebook-jupyter-ubi9-python-3-12-pr-image-mirror	e9ebc01	link	true	/test notebook-jupyter-ubi9-python-3-12-pr-image-mirror
ci/prow/notebook-cuda-jupyter-ubi9-python-3-12-pr-image-mirror	e9ebc01	link	true	/test notebook-cuda-jupyter-ubi9-python-3-12-pr-image-mirror
ci/prow/images	e9ebc01	link	true	/test images
ci/prow/notebook-rocm-jupyter-ubi9-python-3-12-pr-image-mirror	e9ebc01	link	true	/test notebook-rocm-jupyter-ubi9-python-3-12-pr-image-mirror
ci/prow/notebooks-py312-ubi9-e2e-tests	e9ebc01	link	true	/test notebooks-py312-ubi9-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.