RHAIENG-1254: Add command to check Feast package version installed #2630

daniellutz · 2025-10-30T12:57:31Z

Add validation to our CI tests to ensure that the Feast package is being tested as well with running the --version command.

Description

Our build process executes some test commands to ensure that packages are installed properly. These commands are only executed if the package is listed on the ImageStream manifest file, so if the package is not there, the command will be skipped.

This PR aims to add the pip show feast | grep --version command to the CI tests, to ensure that the package is installed properly where applicable.

How Has This Been Tested?

Self checklist (all need to be checked):

Ensure that you have run make test (gmake on macOS) before asking for review

Merge criteria:

The commits are squashed in a cohesive manner and have meaningful messages.
Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
The developer has manually tested the changes and verified that the changes work

Summary by CodeRabbit

Chores
- Updated the software version verification to include Feast in the list of dependencies checked in the container environment. This adds Feast to the runtime checks alongside existing tools, improving consistency of dependency reporting and helping surface version information during build and release processes.

coderabbitai · 2025-10-30T12:57:59Z

Walkthrough

Adds a new entry for Feast to the CI software version verification mapping, associating it with a pip-based shell command that prints Feast's version. No other logic or public signatures were changed.

Changes

Cohort / File(s)	Change Summary
Software version verification mapping `ci/check-software-versions.py`	Added `Feast` key with a pip-based shell command to report its installed version in the existing version-check mapping.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Pay attention to the exact pip command string and quoting to ensure it runs correctly in the CI shell environment.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: adding a command to check the Feast package version. It is concise, directly related to the changeset, and includes the ticket reference (RHAIENG-1254) for context.
Description check	✅ Passed	The PR description covers the main required sections: it explains the purpose (add Feast package validation to CI tests), provides context about how the build process works, describes the specific change (adding pip show feast command), confirms testing was performed, and completes the self-checklist and merge criteria.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e572a54 and 5b35698.

📒 Files selected for processing (1)

ci/check-software-versions.py (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

ci/check-software-versions.py

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: validation-of-sw-versions-in-imagestreams

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

jiridanek · 2025-10-31T09:49:17Z

ci/check-software-versions.py

    output = execute_command_in_container(container_id, command)

    if output and version.lstrip("v") in output:
        log.info(f"{name} version check passed.")


Looking at https://github.com/opendatahub-io/notebooks/actions/runs/18941383446/job/54080793610?pr=2630, I don't see any

feast version check passed

log messages.

Is the check actually running?

this is weird, because I have tested locally and have seen some:

> python ./ci/check-software-versions.py --prune-podman-data [...] 2025-10-31 11:35:09 - INFO - Checking Codeflare-SDK (version 0.32) in container... 2025-10-31 11:35:10 - INFO - Codeflare-SDK version check passed. 2025-10-31 11:35:10 - INFO - Checking Feast (version 0.55) in container... 2025-10-31 11:35:11 - INFO - Feast version check passed. 2025-10-31 11:35:11 - INFO - Checking Sklearn-onnx (version 1.19) in container... 2025-10-31 11:35:12 - INFO - Sklearn-onnx version check passed. 2025-10-31 11:35:12 - INFO - Checking Psycopg (version 3.2) in container... 2025-10-31 11:35:13 - INFO - Psycopg version check passed. [...]

let me take another look on it...

I believe the issue is that all images with tag v1.38 are not running properly, but if I change locally them to v1.37, they run fine here, and all N-1 images do not have Feast, only N

jiridanek

approving, so that you can merge when you're satisfied

openshift-ci · 2025-11-11T12:27:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jiridanek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

daniellutz · 2025-11-11T13:11:22Z

approving, so that you can merge when you're satisfied

now it was possible to see the results there:

...
2025-11-11 12:53:58 - INFO - Checking Codeflare-SDK (version 0.32) in container...
2025-11-11 12:53:59 - INFO - Codeflare-SDK version check passed.
2025-11-11 12:53:59 - INFO - Checking Feast (version 0.55) in container...
2025-11-11 12:54:00 - INFO - Feast version check passed.
2025-11-11 12:54:00 - INFO - Checking Sklearn-onnx (version 1.19) in container...
2025-11-11 12:54:01 - INFO - Sklearn-onnx version check passed.
2025-11-11 12:54:01 - INFO - Checking Psycopg (version 3.2) in container...
...

https://github.com/opendatahub-io/notebooks/actions/runs/19265073917/job/55078846501?pr=2630

openshift-ci-robot · 2025-11-11T13:41:39Z

/retest-required

Remaining retests: 0 against base HEAD bccfcb6 and 2 for PR HEAD 5b35698 in total

openshift-ci-robot · 2025-11-11T15:41:31Z

/retest-required

Remaining retests: 0 against base HEAD 52a5569 and 1 for PR HEAD 5b35698 in total

openshift-ci-robot · 2025-11-11T21:00:42Z

/retest-required

Remaining retests: 0 against base HEAD 603bf2f and 0 for PR HEAD 5b35698 in total

openshift-ci · 2025-11-11T21:49:58Z

@daniellutz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/images	`5b35698`	link	true	`/test images`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2025-11-11T22:00:34Z

/hold

Revision 5b35698 was retested 3 times: holding

openshift-ci bot added do-not-merge/work-in-progress size/xs labels Oct 30, 2025

github-actions bot added the review-requested GitHub Bot creates notification on #pr-review-ai-ide-team slack channel label Oct 30, 2025

openshift-ci bot requested review from dibryant and jiridanek October 30, 2025 12:57

openshift-ci bot added size/xs and removed size/xs labels Oct 30, 2025

daniellutz changed the title ~~WIP: RHAIENG-1254: Add command to check Feast package version installed~~ RHAIENG-1254: Add command to check Feast package version installed Oct 31, 2025

openshift-ci bot added size/xs and removed do-not-merge/work-in-progress size/xs labels Oct 31, 2025

jiridanek requested changes Oct 31, 2025

View reviewed changes

openshift-ci bot assigned jiridanek Oct 31, 2025

Add command to check Feast package version installed

5b35698

daniellutz force-pushed the feast-version-test branch from e572a54 to 5b35698 Compare November 11, 2025 12:07

openshift-ci bot added size/xs and removed size/xs labels Nov 11, 2025

jiridanek approved these changes Nov 11, 2025

View reviewed changes

openshift-ci bot added the lgtm label Nov 11, 2025

openshift-ci bot added the approved label Nov 11, 2025

openshift-ci bot added the do-not-merge/hold label Nov 11, 2025

daniellutz merged commit ad632ba into opendatahub-io:main Nov 13, 2025
13 of 16 checks passed

daniellutz deleted the feast-version-test branch November 13, 2025 14:09

RHAIENG-1254: Add command to check Feast package version installed #2630

RHAIENG-1254: Add command to check Feast package version installed #2630

Uh oh!

Conversation

daniellutz commented Oct 30, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Merge criteria:

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Oct 30, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Pre-merge checks and finishing touches

Uh oh!

jiridanek Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

daniellutz Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

daniellutz Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jiridanek left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Nov 11, 2025

Uh oh!

daniellutz commented Nov 11, 2025

Uh oh!

openshift-ci-robot commented Nov 11, 2025

Uh oh!

openshift-ci-robot commented Nov 11, 2025

Uh oh!

openshift-ci-robot commented Nov 11, 2025

Uh oh!

openshift-ci bot commented Nov 11, 2025

Uh oh!

openshift-ci-robot commented Nov 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

daniellutz commented Oct 30, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Oct 30, 2025 •

edited by openshift-ci bot

Loading

daniellutz Oct 31, 2025 •

edited

Loading