Skip to content

Conversation

@Timoyoungster
Copy link

This adds the option to resample the audio between twilio and realtime, in hopes that by resampling the 8kHz from twilio to 24kHz the looping behaviour from #445 can be alleviated.

I was unable to test whether this actually helps, because I gave up trying after 2 days of struggling with various import errors related to the _shims directories.

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2025

⚠️ No Changeset found

Latest commit: ba60468

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Timoyoungster
Copy link
Author

Timoyoungster commented Oct 27, 2025

I have now managed to test how resampling affects model behavior by implementing the resampling functions directly in the compiled/installed node package.

Unfortunately it did not improve anything, so this pr will not help with regard to #445.

Nevertheless, I think the functionality to process the audio prior to forwarding it could still be useful in some scenarios.

@seratch
Copy link
Member

seratch commented Oct 28, 2025

Thanks for doing further investigation. We don't plan to add this resampling option at this moment, but we'll continue seeing if people need it.

@seratch seratch marked this pull request as draft October 28, 2025 10:14
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2025

This PR is stale because it has been open for 10 days with no activity.

@github-actions github-actions bot added the stale label Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants