fix: fix URLSessionInstrumentation for a missing case #982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beekhc
requested review from
ArielDemarco,
bryce-b,
nachoBonafonte and
vvydier
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a particular way of using
NSURLSessionthat the instrumentation was missing, where a session delegate implements onlyfunc urlSession(_:task:didFinishCollecting:). This was caught by some Honeycomb end-to-end tests that exercise URLSession in various ways. I suspect that this was missed because this method is in the super-protocolNSURLSessionTaskDelegate, rather than theNSURLSessionDataDelegateprotocol.I have verified that our own end-to-end tests fail before this change and pass after.
I've added a regression test to make sure this stays working.