Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 6, 2025

The spec_unstable_logs_enabled feature flag gated the event_enabled method used for log level filtering. This feature is now stable in the OpenTelemetry specification, so the flag is removed and the functionality is always available.

Changes

Core API & SDK

  • opentelemetry: event_enabled method now always available on Logger trait
  • opentelemetry_sdk: event_enabled method now always available on LogProcessor and LogExporter traits
  • All conditional compilation directives removed from log processor implementations

Appenders

  • opentelemetry-appender-tracing: Event filtering always enabled
  • opentelemetry-appender-log: Log level filtering always enabled

Dependencies

  • Feature flag removed from all Cargo.toml files
  • Updated stress and opentelemetry-stdout dependencies

Documentation

  • Updated CHANGELOGs for all affected crates
  • Removed feature flag documentation from lib.rs files
  • Updated benchmark requirements and comments

Migration

Users explicitly enabling the feature flag should remove it from their feature lists:

# Before
opentelemetry = { version = "0.31", features = ["logs", "spec_unstable_logs_enabled"] }

# After
opentelemetry = { version = "0.32", features = ["logs"] }

The functionality remains unchanged—event_enabled is now always available without gating.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • esm.ubuntu.com
    • Triggering command: /usr/lib/apt/methods/https (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>Stabilize logger.enabled in sdk</issue_title>
<issue_description>once open-telemetry/opentelemetry-specification#4536 is merged and released in the spec.

The "spec_unstable_logs_enabled" feature flag needs to be removed completely. All methods/code should be enabled always.
Do this for opentelemetry, opentelemetry_sdk, opentelemetry-appender-tracing and opentelemetry-appender-log crates.
Also update changelog.md file for all above crates to inform of the above change.

Once done, do a thorough search across repo to find any "spec_unstable_logs_enabled" references, and remove them. If there are places where it cannot be removed, create issues to track as follow ups.</issue_description>

Comments on the Issue (you are @copilot in this section)

@cijothomas The "spec_unstable_logs_enabled" feature flag needs to be removed completely. All methods/code should be enabled always. Do this for `opentelemetry`, `opentelemetry_sdk`, `opentelemetry-appender-tracing` and `opentelemetry-appender-log` crates. Also update changelog.md file for all above crates to inform of the above change.

Once done, do a thorough search across repo to find any "spec_unstable_logs_enabled" references, and remove them. If there are places where it cannot be removed, create issues to track as follow ups.</comment_new>


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: cijothomas <5232798+cijothomas@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove spec_unstable_logs_enabled feature flag Stabilize logger.enabled by removing spec_unstable_logs_enabled feature flag Nov 6, 2025
Copilot AI requested a review from cijothomas November 6, 2025 02:33
Copilot finished work on behalf of cijothomas November 6, 2025 02:33
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.8%. Comparing base (cff5728) to head (d6ab4ba).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3225   +/-   ##
=====================================
  Coverage   80.8%   80.8%           
=====================================
  Files        128     128           
  Lines      23288   23288           
=====================================
  Hits       18821   18821           
  Misses      4467    4467           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stabilize logger.enabled in sdk

2 participants