fix: confluent-kafka: fix incorrect number of arguments #3922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papigers
force-pushed
the
confluent-kafka-fix-close-incorrect-num-args
branch
from
f72ac65 to
6dbb8eb
Compare
Contributor
Author
|
@emdneto hoping that you can help with CR here 🙏 |
amitelran-cyera
approved these changes
Nov 5, 2025
xrmx
reviewed
Nov 5, 2025
| [project.optional-dependencies] | ||
| instruments = [ | ||
| "confluent-kafka >= 1.8.2, <= 2.11.0", | ||
| "confluent-kafka >= 1.8.2, <= 2.11.1", |
Contributor
There was a problem hiding this comment.
What do you think of bumping to < 2.12.0? Can we expect to not break?
|
|
||
|
|
||
| _instruments = ("confluent-kafka >= 1.8.2, <= 2.11.0",) | ||
| _instruments = ("confluent-kafka >= 1.8.2, <= 2.11.1",) |
| self._current_context_token = None | ||
|
|
||
| def close(self): | ||
| def close(self, *args, **kwargs): |
Contributor
There was a problem hiding this comment.
Is this something that has been changed in 2.11.1 or has been there already? Maybe we should add a docker test.
Contributor
Author
There was a problem hiding this comment.
I personally only started using in that version, but it doesn't seem to be relevant to confluent Kafka itself, looks to be a change in wrapt that someone forgot to update here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Incorrect wrapping of close() results in the following error:
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.