-
Notifications
You must be signed in to change notification settings - Fork 809
enhance elasticsearch body sanitization #3919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
xrmx
merged 8 commits into
open-telemetry:main
from
mznet:better-elasticsearch-sanitization
Nov 10, 2025
Merged
enhance elasticsearch body sanitization #3919
xrmx
merged 8 commits into
open-telemetry:main
from
mznet:better-elasticsearch-sanitization
Nov 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
fc4629a to
62e324e
Compare
Contributor
|
@mznet thanks, please add a changelog entry |
d5610ea to
1674df0
Compare
Contributor
Author
|
@xrmx i've updated it. |
xrmx
approved these changes
Nov 5, 2025
Contributor
Author
|
@xrmx some tests were failed but i fixed them |
Contributor
|
@mznet please run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The existing
sanitize_bodycan only handle limited types of queries, and sometimes it loses the query structure while sanitizing. It also cannot handle tricky queries like aggregation or script.I improved the body sanitization by masking all values in the leaf nodes. It’s a simple solution, but more clear, no exception, and also keeps the query structure.
Fixes #3876
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I added new queries like term, script, and aggregation to check if sanitize_body can sanitize well and not lose the query structure. I also checked that the existing test queries still keep their structure while masking.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.