-
Notifications
You must be signed in to change notification settings - Fork 808
Fix a few bugs in opentelemetry-instrumentation-google-genai instrumentation package
#3905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DylanRussell
wants to merge
8
commits into
open-telemetry:main
Choose a base branch
from
DylanRussell:fixbug
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+296
−202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opentelemetry-instrumentation-google-genai instrumentation package
6 tasks
aabmass
approved these changes
Nov 11, 2025
...trumentation-google-genai/src/opentelemetry/instrumentation/google_genai/generate_content.py
Show resolved
Hide resolved
...trumentation-google-genai/src/opentelemetry/instrumentation/google_genai/generate_content.py
Show resolved
Hide resolved
...trumentation-google-genai/src/opentelemetry/instrumentation/google_genai/generate_content.py
Show resolved
Hide resolved
...trumentation-google-genai/src/opentelemetry/instrumentation/google_genai/generate_content.py
Outdated
Show resolved
Hide resolved
...trumentation-google-genai/src/opentelemetry/instrumentation/google_genai/generate_content.py
Outdated
Show resolved
Hide resolved
...trumentation-google-genai/src/opentelemetry/instrumentation/google_genai/generate_content.py
Outdated
Show resolved
Hide resolved
instrumentation-genai/opentelemetry-instrumentation-google-genai/tests/generate_content/base.py
Outdated
Show resolved
Hide resolved
instrumentation-genai/opentelemetry-instrumentation-google-genai/tests/generate_content/base.py
Outdated
Show resolved
Hide resolved
...genai/opentelemetry-instrumentation-google-genai/tests/generate_content/nonstreaming_base.py
Outdated
Show resolved
Hide resolved
instrumentation-genai/opentelemetry-instrumentation-google-genai/CHANGELOG.md
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pydantic.BaseModelclass was passed as the response schema toGenerateContentConfig, the code expected a class instance for some reason (see BaseModel.model_dump() called on class instead of instance in opentelemetry-instrumentation-google-genai #3596).error.typesem conv attribute when there's an exception raised._maybe_log_completion_details(function call into thefinallyblock for the 4 instrumentation variants (sync/async streaming/non). This ensures we always write the event and call the completion hook etc. even when there's an exception thrown.gen_ai.client.inference.operation.detailslog event is written and completion upload hook are called whenOTEL_SEMCONV_STABILITY_OPT_IN=gen_ai_latest_experimental.Fixes #3596
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit tests
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.