fix(knex-instrumentation): use correct db system attribute

[pantajoe]

Which problem is this PR solving?

MikroORM overrides the default postgres client in knex to a PostreSqlKnexDialect, so Knex.client.config.client is not a string, but an instance to that dialect class.

Therefore, for users of an ORM that does this with knex, the knex instrumentation triggers a bunch of Invalid attribute set for database.system.name warnings.

Short description of the changes

Use knex.Client.config.driverName instead of knex.Client.config.client to derive the DB system attribute: database.system.name (or the deprecated one database.system)

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: david-luna / name: David Luna (6599929)

[raphael-theriault-swi]

Could you add a test case that illustrates the issue being fixed, and to make sure there isn't a regression in the future ?

[github-actions]

This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature.
Are you familiar with this package? Consider becoming a component owner.

[pantajoe]

Could you add a test case that illustrates the issue being fixed, and to make sure there isn't a regression in the future ?

Done ✅

[david-luna]

@pantajoe

I've started the workflows but I'm not sure if this change will be compatible with all the versions supported >=0.10.0 <4.

Update: unit tests pass but we only test with the version set in package.json. There is no other version tested

Run npm run test-all-versions:ci:affected

> opentelemetry-js-contrib@0.1.0 test-all-versions:ci:affected
> npm --loglevel=silent run list:affected | xargs -I {} -t npm run --if-present test-all-versions -w {}

[david-luna]

Tested down to v1.0.0 locally with the changes in #3221 and no errors :)

Let's merge #3221 first so we see the tests results in CI.

[pantajoe]

Nice, happy to hear that 👍🏽

[otelbot]

Thank you for your contribution @pantajoe! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.