Add system properties bridge #15339

zeitlinger · 2025-11-17T17:09:09Z

to bridge system properties / env vars to declarative config

Alternative implementation for #14767

zeitlinger · 2025-11-17T17:44:45Z

@trask I really like this new bridge based on your idea 😄

trask · 2025-11-24T22:44:45Z

...on-api/src/main/java/io/opentelemetry/instrumentation/api/internal/ConfigPropertiesUtil.java

+  private static final boolean isIncubator = isIncubator();
+
+  private static boolean isIncubator() {


maybe supportsDeclarativeConfig? based on comment below it sounds like we'll still need this once it's out of incubation?

no, when it's out of incubation, we'll have

public static boolean isDeclarativeConfig(OpenTelemetry openTelemetry) { return openTelemetry instanceof ExtendedOpenTelemetry; }

or

public static boolean isDeclarativeConfig(OpenTelemetry openTelemetry) { return openTelemetry.getConfigProvider() != null; }

instead of

public static boolean isDeclarativeConfig(OpenTelemetry openTelemetry) { return isIncubator && openTelemetry instanceof ExtendedOpenTelemetry; }

depending on how things will evolve.

With the name change, it would be

public static boolean isDeclarativeConfig(OpenTelemetry openTelemetry) { return supportsDeclarativeConfig && openTelemetry instanceof ExtendedOpenTelemetry; }

which is similar in clarity to what we have now - so I'll go with your proposal

trask · 2025-11-24T22:47:44Z

...on-api/src/main/java/io/opentelemetry/instrumentation/api/internal/ConfigPropertiesUtil.java

+  public static boolean getBoolean(
+      OpenTelemetry openTelemetry, boolean defaultValue, String... propertyName) {


what about:

public static Optional getBoolean(OpenTelemetry, String...)

then used as:

getBoolean(...).orElse(...)

I like it, but I want to keep things consistent - so I'll change it for all methods.

The class in internal, so it's allowed.

I want to keep things consistent - so I'll change it for all methods.

I understand, but this increases the PR size and harder to review. We can always discuss/change the others in a follow-up

I'd prefer to change it only for the ones that take varargs in this PR at least, since those are new and readability benefits most from the Optional pattern

Agreed - split off #15479

trask · 2025-11-24T22:52:47Z

...on-api/src/main/java/io/opentelemetry/instrumentation/api/internal/ConfigPropertiesUtil.java

+      // This only happens in OpenTelemetry API instrumentation tests, where an older version of
+      // OpenTelemetry API is used that does not have ExtendedOpenTelemetry.
+      // Having the incubator module without ExtendedOpenTelemetry class should still return false
+      // for those tests to avoid a ClassNotFoundException.


This only happens in OpenTelemetry API instrumentation tests

these are tests of OpenTelemetry API in the users class loader, so not following how that affects this class which is in the agent?

without the check, we get tests where the incubator exists, but is too old to have ExtendedOpenTelemetry:

gradle :instrumentation:opentelemetry-api:opentelemetry-api-1.42:javaagent:incubatorTest

at io.opentelemetry.instrumentation.api.internal.ConfigPropertiesUtil.isDeclarativeConfig(ConfigPropertiesUtil.java:116) at io.opentelemetry.instrumentation.api.instrumenter.InstrumenterBuilder.buildSpanSuppressor(InstrumenterBuilder.java:374) at io.opentelemetry.instrumentation.api.instrumenter.Instrumenter.<init>(Instrumenter.java:105) at io.opentelemetry.instrumentation.api.instrumenter.InstrumenterBuilder.buildInstrumenter(InstrumenterBuilder.java:298) at io.opentelemetry.instrumentation.api.instrumenter.InstrumenterBuilder.buildInstrumenter(InstrumenterBuilder.java:287) at io.opentelemetry.instrumentation.testing.TestInstrumenters.<init>(TestInstrumenters.java:41) at io.opentelemetry.instrumentation.testing.InstrumentationTestRunner.<init>(InstrumentationTestRunner.java:68) at io.opentelemetry.instrumentation.testing.AgentTestRunner.<init>(AgentTestRunner.java:47) at io.opentelemetry.instrumentation.testing.AgentTestRunner.<clinit>(AgentTestRunner.java:40) at io.opentelemetry.instrumentation.testing.junit.AgentInstrumentationExtension.<init>(AgentInstrumentationExtension.java:35) at io.opentelemetry.instrumentation.testing.junit.AgentInstrumentationExtension.create(AgentInstrumentationExtension.java:39) at io.opentelemetry.javaagent.instrumentation.opentelemetryapi.v1_42.incubator.logs.LoggerTest.<clinit>(LoggerTest.java:41) at java.base/jdk.internal.misc.Unsafe.ensureClassInitialized0(Native Method) at java.base/jdk.internal.misc.Unsafe.ensureClassInitialized(Unsafe.java:1160) at java.base/java.lang.reflect.Field.acquireOverrideFieldAccessor(Field.java:1200) at java.base/java.lang.reflect.Field.getOverrideFieldAccessor(Field.java:1169) at java.base/java.lang.reflect.Field.get(Field.java:444) at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184) at java.base/java.util.ArrayList.forEach(ArrayList.java:1596) at java.base/java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395) at java.base/java.util.stream.DistinctOps$1$2.end(DistinctOps.java:168) at java.base/java.util.stream.Sink$ChainedReference.end(Sink.java:261) at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:510) at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151) at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174) at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596) at java.base/java.util.ArrayList.forEach(ArrayList.java:1596) Caused by: java.lang.ClassNotFoundException: io.opentelemetry.api.incubator.ExtendedOpenTelemetry at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641) at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526) ... 29 more

trask · 2025-11-24T22:53:31Z

...on-api/src/main/java/io/opentelemetry/instrumentation/api/internal/ConfigPropertiesUtil.java

+  /** Returns true if the given OpenTelemetry instance supports Declarative Config. */
+  public static boolean isDeclarativeConfig(OpenTelemetry openTelemetry) {
+    return isIncubator && openTelemetry instanceof ExtendedOpenTelemetry;
+  }
+


is isIncubator needed, since instrumentation-api (unfortunately) already depends on the api-incubator?

only for the test (see last comment)

zeitlinger · 2025-11-25T14:56:48Z

I have no idea what could have caused this failure:

11:31:59.660 [Test worker] INFO  t.g.i.19421579350 - Pulling docker image: ghcr.io/open-telemetry/opentelemetry-java-instrumentation/smoke-test-zulu-openjdk-8u31:20251117.19421579350. Please be patient; this may take some time but only needs to be done once.
11:32:00.526 [docker-java-stream--1576344563] INFO  t.g.i.19421579350 - Starting to pull image
11:32:00.527 [docker-java-stream--1576344563] INFO  t.g.i.19421579350 - Pulling image layers:  0 pending,  0 downloaded,  0 extracted, (0 bytes/0 bytes)
11:32:00.983 [docker-java-stream--1576344563] INFO  t.g.i.19421579350 - Pulling image layers:  1 pending,  1 downloaded,  0 extracted, (13 MB/? MB)
11:32:01.834 [docker-java-stream--1576344563] INFO  t.g.i.19421579350 - Pulling image layers:  1 pending,  1 downloaded,  1 extracted, (129 MB/? MB)
11:32:01.972 [docker-java-stream--1576344563] INFO  t.g.i.19421579350 - Pulling image layers:  0 pending,  2 downloaded,  1 extracted, (143 MB/148 MB)
11:32:03.747 [docker-java-stream--1576344563] INFO  t.g.i.19421579350 - Pulling image layers:  0 pending,  2 downloaded,  2 extracted, (148 MB/148 MB)
11:32:03.751 [Test worker] INFO  t.g.i.19421579350 - Image ghcr.io/open-telemetry/opentelemetry-java-instrumentation/smoke-test-zulu-openjdk-8u31:20251117.19421579350 pull took PT4.090551S
11:32:03.751 [docker-java-stream--1576344563] INFO  t.g.i.19421579350 - Pull complete. 2 layers, pulled in 3s (downloaded 148 MB at 49 MB/s)
11:32:03.753 [Test worker] INFO  t.g.i.19421579350 - Creating container for image: ghcr.io/open-telemetry/opentelemetry-java-instrumentation/smoke-test-zulu-openjdk-8u31:20251117.19421579350
11:32:04.376 [Test worker] INFO  t.g.i.19421579350 - Container ghcr.io/open-telemetry/opentelemetry-java-instrumentation/smoke-test-zulu-openjdk-8u31:20251117.19421579350 is starting: d09147ceccc4abd46f5c923ad2025cb51e2f7d27659e9b20370bf9c4d5e45420
11:32:04.459 [docker-java-stream-822006274] INFO  i.o.smoketest.CrashEarlyJdk8Test - STDOUT: started
11:32:04.467 [Test worker] INFO  t.g.i.19421579350 - Container ghcr.io/open-telemetry/opentelemetry-java-instrumentation/smoke-test-zulu-openjdk-8u31:20251117.19421579350 started in PT0.713852S
Container.ExecResult(exitCode=134, stdout=compiling
finish compiling
executing
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x000000076e60fe08, pid=31, tid=140468591523520
#
# JRE version: OpenJDK Runtime Environment (8.0_31-b13) (build 1.8.0_31-b13)
# Java VM: OpenJDK 64-Bit Server VM (25.31-b07 mixed mode linux-amd64 compressed oops)
# Problematic frame:
# C  0x000000076e60fe08
#
# Core dump written. Default location: //core or core.31
#
# An error report file with more information is saved as:
# //hs_err_pid31.log
Compiled method (c1)     807 1777       3       java.util.stream.AbstractPipeline::wrapSink (37 bytes)
 total in heap  [0x00007fc150965350,0x00007fc150965a78] = 1832
 relocation     [0x00007fc150965478,0x00007fc1509654e0] = 104
 main code      [0x00007fc1509654e0,0x00007fc150965840] = 864
 stub code      [0x00007fc150965840,0x00007fc1509658f8] = 184
 metadata       [0x00007fc1509658f8,0x00007fc150965908] = 16
 scopes data    [0x00007fc150965908,0x00007fc1509659a8] = 160
 scopes pcs     [0x00007fc1509659a8,0x00007fc150965a58] = 176
 dependencies   [0x00007fc150965a58,0x00007fc150965a60] = 8
 nul chk table  [0x00007fc150965a60,0x00007fc150965a78] = 24
Compiled method (c1)     807 1782       3       java.util.stream.StreamSpliterators$WrappingSpliterator$$Lambda$254/1777443462::get$Lambda (9 bytes)
 total in heap  [0x00007fc15096f350,0x00007fc15096f7e8] = 1176
 relocation     [0x00007fc15096f478,0x00007fc15096f4b8] = 64
 main code      [0x00007fc15096f4c0,0x00007fc15096f680] = 448
 stub code      [0x00007fc15096f680,0x00007fc15096f710] = 144
 oops           [0x00007fc15096f710,0x00007fc15096f718] = 8
 metadata       [0x00007fc15096f718,0x00007fc15096f730] = 24
 scopes data    [0x00007fc15096f730,0x00007fc15096f780] = 80
 scopes pcs     [0x00007fc15096f780,0x00007fc15096f7e0] = 96
 dependencies   [0x00007fc15096f7e0,0x00007fc15096f7e8] = 8
#
# If you would like to submit a bug report, please visit:
#   http://www.azulsystems.com/support/
#
, stderr=[otel.javaagent 2025-11-25 11:32:05:162 +0000] [main] INFO io.opentelemetry.javaagent.tooling.VersionLogger - opentelemetry-javaagent - version: 2.23.0-SNAPSHOT
/test.sh: line 7:    31 Aborted                 (core dumped) java -javaagent:opentelemetry-javaagent.jar CrashEarlyJdk8
)

laurit · 2025-11-25T15:21:59Z

I have no idea what could have caused this failure:

CrashEarlyJdk8 fails when you use lambdas too early in the agent initalization.

zeitlinger · 2025-11-25T15:54:56Z

I have no idea what could have caused this failure:

CrashEarlyJdk8 fails when you use lambdas too early in the agent initalization.

thank you!

zeitlinger · 2025-11-26T11:16:41Z

@trask please check again

…gProperties

zeitlinger · 2025-11-27T13:34:18Z

...va/io/opentelemetry/instrumentation/awssdk/v2_2/internal/AbstractAwsSdkTelemetryFactory.java

  private boolean useMessagingPropagator() {
-    return getBoolean(
-        "otel.instrumentation.aws-sdk.experimental-use-propagator-for-messaging", false);
+    return getBoolean(false, "aws_sdk", "experimental_use_propagator_for_messaging");


should experimental be an indent level?

zeitlinger self-assigned this Nov 17, 2025

zeitlinger requested a review from a team as a code owner November 17, 2025 17:09

github-actions bot added the test native This label can be applied to PRs to trigger them to run native tests label Nov 17, 2025

zeitlinger mentioned this pull request Nov 17, 2025

Jdbc declarative config params #15199

Draft

zeitlinger added this to Declarative Configuration: Java Nov 17, 2025

zeitlinger moved this to Awaiting Review in Declarative Configuration: Java Nov 17, 2025

zeitlinger changed the title ~~Add system properties bridge~~ Add system properties bridge, part 1 Nov 17, 2025

zeitlinger force-pushed the system-properties-bridge branch from 3a9e285 to 9ae95f1 Compare November 18, 2025 09:54

zeitlinger changed the title ~~Add system properties bridge, part 1~~ Add system properties bridge Nov 18, 2025

trask reviewed Nov 24, 2025

View reviewed changes

zeitlinger force-pushed the system-properties-bridge branch from 0138d4f to 16e62ea Compare November 25, 2025 08:15

zeitlinger added 14 commits November 27, 2025 14:00

add system properties bridge

08e70a0

add system properties bridge

5c1638f

add tests

f503dbe

add list

246fc71

refactor

add113a

refactor

a0525ac

string

bca6ff1

string

556b9c3

string

1109153

string

5dba36a

string

3bccdf7

string

652eb54

string

06e76b0

string

d7d11a2

zeitlinger added 17 commits November 27, 2025 14:00

javadoc

894b836

add contract

f25fcd5

add contract

acc63dd

remove contract

55f7cd0

remove contract

1ea8025

inline method to avoid class not found exception for DeclarativeConfi…

2e81251

…gProperties

pr review

4ac86c4

use optional instead of providing default for boolean

17d3014

use optional instead of providing default for int

2897e57

use optional instead of providing default for list

ce07aa3

use optional instead of providing default for string

83e23eb

fix

2b5e2c4

fix

fdbee40

fix

aab3eed

fix

0f400ab

split pr

3fd7b6f

split pr

18d719d

zeitlinger force-pushed the system-properties-bridge branch from cf18ce0 to 18d719d Compare November 27, 2025 13:15

zeitlinger mentioned this pull request Nov 27, 2025

clean up ConfigPropertiesUtil #15479

Draft

zeitlinger commented Nov 27, 2025

View reviewed changes

zeitlinger added 3 commits November 27, 2025 16:17

Merge branch 'main' into system-properties-bridge

3b42108

fix

7c09f40

fix

55146b8

		private static final boolean isIncubator = isIncubator();

		private static boolean isIncubator() {

		public static boolean getBoolean(
		OpenTelemetry openTelemetry, boolean defaultValue, String... propertyName) {

Add system properties bridge #15339

Are you sure you want to change the base?

Add system properties bridge #15339

Uh oh!

Conversation

zeitlinger commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zeitlinger commented Nov 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zeitlinger commented Nov 25, 2025

Uh oh!

laurit commented Nov 25, 2025

Uh oh!

zeitlinger commented Nov 25, 2025

Uh oh!

zeitlinger commented Nov 26, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zeitlinger commented Nov 17, 2025 •

edited

Loading