-
Notifications
You must be signed in to change notification settings - Fork 47
Add support for Opensearch client span #871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #871 +/- ##
==========================================
- Coverage 55.15% 55.13% -0.02%
==========================================
Files 251 251
Lines 21481 21494 +13
==========================================
+ Hits 11847 11850 +3
- Misses 8818 8828 +10
Partials 816 816
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mmat11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments, CI is failing, probably a rebase is needed
1a3338d to
3ae6df6
Compare
mmat11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a couple more comments, lgtm!
3ae6df6 to
4aee72f
Compare
Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>
4aee72f to
fb4aaab
Compare
|
Can we add a row for opensearch in devdocs/features.md? |
Oh, sure! |
Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>
This PR introduces support for Opensearch client span, continuing the work already done for Elasticsearch (#801 and #853)
Opensearch doesn't have an opentelemetry semconv, so I reused Elasticsearch's with the only difference being the
db.system.namefield.Moreoveor, to avoid duplicating code, I rewrote the tests and the python testserver to make it generic.