Skip to content

Conversation

@pinoOgni
Copy link
Contributor

@pinoOgni pinoOgni commented Nov 6, 2025

This PR introduces support for Opensearch client span, continuing the work already done for Elasticsearch (#801 and #853)

Opensearch doesn't have an opentelemetry semconv, so I reused Elasticsearch's with the only difference being the db.system.name field.
Moreoveor, to avoid duplicating code, I rewrote the tests and the python testserver to make it generic.

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.13%. Comparing base (f20e96e) to head (fdfa55d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/ebpf/common/http/elasticsearch.go 0.00% 13 Missing ⚠️
pkg/appolly/app/request/span.go 0.00% 1 Missing ⚠️
pkg/appolly/app/request/span_getters.go 0.00% 1 Missing ⚠️
pkg/export/otel/tracesgen/tracesgen.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #871      +/-   ##
==========================================
- Coverage   55.15%   55.13%   -0.02%     
==========================================
  Files         251      251              
  Lines       21481    21494      +13     
==========================================
+ Hits        11847    11850       +3     
- Misses       8818     8828      +10     
  Partials      816      816              
Flag Coverage Δ
integration-test 23.27% <0.00%> (-0.02%) ⬇️
integration-test-arm 0.00% <0.00%> (?)
integration-test-vm-${ARCH}-${KERNEL_VERSION} 0.00% <0.00%> (?)
k8s-integration-test 2.76% <0.00%> (-0.02%) ⬇️
oats-test 0.00% <0.00%> (ø)
unittests 46.25% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pinoOgni pinoOgni closed this Nov 6, 2025
@pinoOgni pinoOgni reopened this Nov 7, 2025
Copy link
Contributor

@mmat11 mmat11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments, CI is failing, probably a rebase is needed

@pinoOgni pinoOgni marked this pull request as ready for review November 7, 2025 15:18
@pinoOgni pinoOgni requested a review from a team as a code owner November 7, 2025 15:18
Copy link
Contributor

@mmat11 mmat11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a couple more comments, lgtm!

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>
@NimrodAvni78
Copy link
Contributor

Can we add a row for opensearch in devdocs/features.md?

@pinoOgni
Copy link
Contributor Author

pinoOgni commented Nov 7, 2025

Can we add a row for opensearch in devdocs/features.md?

Oh, sure!

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants