-
Notifications
You must be signed in to change notification settings - Fork 32
Add schema modeling guidance for enum values as lower_snake_case #445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add schema modeling guidance for enum values as lower_snake_case #445
Conversation
MrAlias
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the values be case-insensitive? Do we want to distinguish between info and INFO?
|
JSON schema doesn't support case insensitive enum values @MrAlias. I would be in favor of case insensitivity if we could express it reasonably |
1 similar comment
|
JSON schema doesn't support case insensitive enum values @MrAlias. I would be in favor of case insensitivity if we could express it reasonably |
|
In that case, can we use uppercase snake case to match existing definitions like the log severity? |
…y-configuration into consistent-enum-value-casing
|
See #449. Notably:
|
|
i prefer the lower case to upper case option |
codeboten
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can address the conflicts and update the description for the enum, i think we can move this forward
…y-configuration into consistent-enum-value-casing
…k-berg/opentelemetry-configuration into consistent-enum-value-casing
|
I don't have a strong preference on casing. Just more used to the upper-case. |
Realized we don't consistently model enum value types when reviewing this spec PR.
Ideally, we would have case insensitive enums, but JSON schema doesn't support those without resorting to using regex patterns.
Choosing snake case because we already have modeling guidance saying that property names are snake case.