Default behavior todos #435
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #426.
Common themes:
defaultBehavior: ignore.defaultBeahvior: default values as described in <type> are usedThere weren't too many default behaviors that were completely missing. Mostly just dots that needed to be connected.
There was only one case where the defaults were unspecified and not obvious - the jaeger remote sampler. I made
endpointandinitial_samplerrequired, and set thedefaultBehavior: 60000 is usedforinternal(the default in java but not defined in the spec). This case isn't too important because we marked jaeger remote sampler as experimental in #363.