Moodle 5.1 compatibility #126
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aolley
requested changes
Oct 29, 2025
| * | ||
| * @package mod_lightboxgallery | ||
| */ | ||
| class backup_lightboxgallery_activity_task extends backup_activity_task { |
Collaborator
There was a problem hiding this comment.
@lucaboesch Moodle coding style has the opening brace for classes on the same line as the class name - not the next line (same as function declarations). I'm guessing your lint rules or whatever you're using to check these is missing that?
Author
There was a problem hiding this comment.
Thanks!
If you could check again, please?
Best,
Luca
lucaboesch
force-pushed
the
moodle501
branch
4 times, most recently
from
e6c4abe to
78f87fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets your plugin run green with Moodle 5.1.