Skip to content

fix: Fix StackOverflow on recursive contexts #1760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Fix StackOverflow on recursive contexts #1760

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4e1020
Fix StackOverflow on recursive contexts
chrfwow Dec 2, 2025
088d6d7
Fix StackOverflow on recursive contexts
chrfwow Dec 2, 2025
3754f75
Fix StackOverflow on recursive contexts
chrfwow Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/dev/openfeature/sdk/HookSupport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ public void executeBeforeHooks(HookSupportData data) {
.orElse(Optional.empty());
if (returnedEvalContext.isPresent()) {
var returnedContext = returnedEvalContext.get();
if (!returnedContext.isEmpty()) {
// yes, we want to check for reference equality here, this prevents recursive layered contexts
if (returnedContext != hookContext.getCtx() && !returnedContext.isEmpty()) {
Copy link
Contributor

@alexandraoberaigner alexandraoberaigner Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (returnedContext != hookContext.getCtx() && !returnedContext.isEmpty()) {
if (!returnedContext.isEmpty() && returnedContext != hookContext.getCtx()) {

[Q] would java optimize this anyway or could this be a slight improvement checking for empty first?

data.evaluationContext.putHookContext(returnedContext);
}
}
Expand Down
24 changes: 24 additions & 0 deletions src/test/java/dev/openfeature/sdk/HookSupportTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package dev.openfeature.sdk;

import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatNoException;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
Expand Down Expand Up @@ -113,6 +114,29 @@ void shouldIsolateDataBetweenHooks(FlagValueType flagValueType) {
assertHookData(testHook2, 2, "before", "after", "finallyAfter", "error");
}

@Test
void hookThatReturnsTheGivenContext_doesNotResultInAStackOverflow() {
var hookSupportData = new HookSupportData();
var recursiveHook = new Hook() {
@Override
public Optional<EvaluationContext> before(HookContext ctx, Map hints) {
return Optional.of(ctx.getCtx());
}
};
var layeredEvaluationContext =
new LayeredEvaluationContext(evaluationContextWithValue("key", "value"), null, null, null);
hookSupportData.evaluationContext = layeredEvaluationContext;
hookSupport.setHooks(hookSupportData, List.of(recursiveHook), FlagValueType.STRING);
hookSupport.setHookContexts(
hookSupportData, getBaseHookContextForType(FlagValueType.STRING), layeredEvaluationContext);

callAllHooks(hookSupportData);

layeredEvaluationContext.asObjectMap();

assertThatNoException();
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The use of assertThatNoException() here is not idiomatic. It creates an assertion object that is not used, and the test relies on an uncaught exception to fail. A more explicit and robust way to assert that no exception is thrown is to use isThrownBy() with a lambda or method reference. This clearly states which part of the code is expected not to throw an exception.

Suggested change
layeredEvaluationContext.asObjectMap();
assertThatNoException();
assertThatNoException().isThrownBy(layeredEvaluationContext::asObjectMap);

}

private static void callAllHooks(HookSupportData hookSupportData) {
hookSupport.executeBeforeHooks(hookSupportData);
hookSupport.executeAfterHooks(
Expand Down
Loading