-
Notifications
You must be signed in to change notification settings - Fork 846
feat(inspect): Auto-run pipeline #3166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inspect): Auto-run pipeline #3166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements auto-run functionality for the inspect pipeline and adds FPS display. The pipeline now automatically starts when all required components (source, sink, and model) are configured. The changes also include UI improvements like removing the enable switch, adding a refresh button for webcam devices, and displaying real-time FPS metrics.
Key changes:
- Auto-run pipeline when source, sink, and model are all configured
- Display FPS (frames per second) metrics during streaming
- Add Models tab to pipeline configuration dialog
- Replace manual pipeline switch with automatic activation logic
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| application/ui/src/index.css | Updated energy-blue color from rgb to hex format and added tab selection indicator styling |
| application/ui/src/hooks/use-pipeline.hook.ts | Fixed import path from absolute to relative |
| application/ui/src/features/inspect/toolbar/toolbar.tsx | Refactored toolbar to use PipelineConfiguration component and removed PipelineSwitch |
| application/ui/src/features/inspect/toolbar/sources/webcam/webcam-fields.component.tsx | Added refresh button for camera devices with loading state |
| application/ui/src/features/inspect/toolbar/pipeline-configuration.component.tsx | Renamed component and added Models tab to pipeline configuration |
| application/ui/src/features/inspect/toolbar/models-picker.component.tsx | Removed old model picker component (replaced by ModelsList) |
| application/ui/src/features/inspect/toolbar/models-list/models-list.test.tsx | Added comprehensive tests for new ModelsList component |
| application/ui/src/features/inspect/toolbar/models-list/models-list.component.tsx | Implemented new ModelsList component with selection handling |
| application/ui/src/features/inspect/stream/stream.tsx | Added Fps component to stream view |
| application/ui/src/features/inspect/stream/stream-container.tsx | Integrated auto-play functionality and simplified start logic |
| application/ui/src/features/inspect/stream/hook/use-auto-play-stream.test.tsx | Added tests for auto-play stream hook |
| application/ui/src/features/inspect/stream/hook/use-auto-play-stream.hook.tsx | Implemented auto-play logic for pipeline |
| application/ui/src/features/inspect/stream/fps/fps.test.tsx | Added tests for FPS component |
| application/ui/src/features/inspect/stream/fps/fps.component.tsx | Implemented FPS display component |
| application/ui/src/features/inspect/footer/footer.component.tsx | Refactored to use patchPipeline and reorganized code structure |
| application/ui/src/features/inspect/dataset/dataset-list.component.tsx | Fixed TODO comment formatting |
| application/ui/mocks/mock-model.ts | Added mock model factory for tests |
| application/ui/mocks/mock-metrics.ts | Added mock metrics factory for tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
application/ui/src/features/inspect/stream/hook/use-auto-play-stream.hook.tsx
Outdated
Show resolved
Hide resolved
application/ui/src/features/inspect/stream/fps/fps.component.tsx
Outdated
Show resolved
Hide resolved
application/ui/src/features/inspect/stream/fps/fps.component.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Colorado, Camilo <camilo.colorado@intel.com>
Signed-off-by: Colorado, Camilo <camilo.colorado@intel.com>
Signed-off-by: Colorado, Camilo <camilo.colorado@intel.com>
Signed-off-by: Colorado, Camilo <camilo.colorado@intel.com>
Signed-off-by: Colorado, Camilo <camilo.colorado@intel.com>
a0f84d1 to
0df597a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
application/ui/src/features/inspect/stream/hook/use-auto-play-stream.hook.tsx
Show resolved
Hide resolved
application/ui/src/features/inspect/toolbar/models-list/models-list.component.tsx
Outdated
Show resolved
Hide resolved
application/ui/src/features/inspect/stream/fps/fps.component.tsx
Outdated
Show resolved
Hide resolved
application/ui/src/features/inspect/footer/footer.component.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Colorado, Camilo <camilo.colorado@intel.com>
debecff to
65ddd94
Compare
65ddd94 to
1489952
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
application/ui/src/features/inspect/stream/hook/use-auto-play-stream.hook.tsx
Show resolved
Hide resolved
application/ui/src/features/inspect/models/model-actions-menu.component.tsx
Show resolved
Hide resolved
Signed-off-by: Colorado, Camilo <camilo.colorado@intel.com>
1489952 to
fdca067
Compare
| const patchPipeline = usePatchPipeline(projectId); | ||
|
|
||
| const hasSelectedModel = pipeline?.model?.id !== undefined; | ||
| const hasNonAvailableModels = models.length === 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we filter the models with is_ready or status==Completed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree, I'll update it on my next PR
688e92d
into
open-edge-platform:feature/geti-inspect
📝 Description
Screen.Recording.2025-12-01.at.17.13.49.mov
#3171
#3169
REmove enable sqitch
aouto run pipeline when is active and has souce,sink and model
show fps
Provide a clear summary of the changes and the issue that has been addressed.
🛠️ Fixes # (issue number)
✨ Changes
Select what type of change your PR is:
✅ Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.