📦 feat(inspect): Add docker build #3136

ashwinvaidya17 · 2025-11-21T09:30:10Z

📝 Description

Add CPU build

TODO

Add GPU build
Add XPU build

✨ Changes

Select what type of change your PR is:

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

📚 I have made the necessary updates to the documentation (if applicable).
🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).
🏷️ My PR title follows conventional commit format.

For more information about code review checklists, see the Code Review Checklist.

Mainly based on the UI files and architecture from [Geti Tune](https://github.com/open-edge-platform/training_extensions/tree/develop/ui)

* initial backend commit Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * app -> src Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * Remove empty file Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * move code Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * fix style backend Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * rename media endpoint Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> --------- Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com>

…#2942) add unit tests for endpoints Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com>

These won't be needed yet

…tform#2948) * Use src folder inside run.sh * Set openapi_url path * Update to react 19 * Specify bash language in readme

…edge-platform#2945) * add training + inference endpoint Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * remove model api Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * cleanup code Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * update async execution Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * improve training worker loop and predict endpoint Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * fix style Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * fix style to use python3.10 generics Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * add tests for services Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * style fix Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * style fix Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * style fix Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * style fix Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * style fix Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> --------- Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com>

…edge-platform#2961) * Add github actions for ui and server of geti inspect * Exclude UI from pre-commit prettier configuration The UI uses a different prettier configuration that does not seem to be picked up by pre-commit. * Add newline to .prettierignore * Apply prettier to `geti-inspect.yaml` * Generate OpenAPI spec before running UI checks * Checkout with lfs * Fix lint issues by removing wip components * Try installing git lfs in the playwright docker image * Fix unused noqa

…edge-platform#2963) * Add OpenAPI route * Remove MSW browser worker * Rename infernece to inspect * Update navbar title * Rename infernece to inspect

* rename models/ to pydantic_models/ Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * switch to use async session context manager Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * fix unit tests Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * add pipeline endpoints Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * fix frame aquisition worker and rename pipiline endpoints Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * add sources and sinks endpoints Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * stream loading working Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * add webrtc endpoints Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * fix workers: stream loading + inference + dispatcher Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * fix sinks Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * style Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * add unit tests and address comments Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * add tests Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * fix example schema Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * add todo Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> --------- Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com>

…2970) * chore: Add path alias to icons * feat: Add sidebar with dataset, models and stats

* feat: Display placeholders for images * refactor: Fix scrollbar * chore: Remove learn more

* chore(inspect): Update UI scripts * chore: Update github actions * chore: Update port to 8000

…en-edge-platform#2978) chore(inspect): Configure project(s) mocks for playwright

* chore: Add project route * feat: Add project management * revert ui lock change * chore: Remove not needed code for project management

…ts from the UI (open-edge-platform#2980) chore(inspect): Update allowed origins

… training progress (open-edge-platform#2984) * feat: Allow user to upload images * feat: List uploaded images * chore: Extract components to separate files and add ready to train and training progress * chore: comment thumbnail url generation

chore(inspect): Update openapi page title

…en-edge-platform#2989) * chore(inspect): Renamed app to application * chore(inspect): Rename app to application in github actions

…of email (open-edge-platform#2990) refactor: Update photo placeholder to use indicator instead of email

…dge-platform#2991) Improve error and suspense handling in router By moving all of the routes into a single root route we can make sure that all routes are rendered inside of an layout that has a suspense and error boundary.

Signed-off-by: Ashwin Vaidya <ashwin.vaidya@intel.com>

…open-edge-platform#2992) refactor: Improvements to the jobs management and training

…platform#2994) chore(inspect): Add more models

🐛 fix(inspect): Fix unable to start train job

chore(inspect): Update uv.lock

* add trainable models endpoint * fix Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * add test Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * add copyright Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> --------- Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com>

…rm#3004) * add thumbnails endpoint Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * add tests Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * generate thumbnails as background task Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> * update docstring Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com> --------- Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com>

Signed-off-by: Ashwin Vaidya <ashwin.vaidya@intel.com>

Copilot

Pull request overview

Copilot reviewed 26 out of 29 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-01T13:50:03Z

application/backend/src/main.py

-        "http://localhost:9000",
-        "http://127.0.0.1:9000",
-    ],
+    allow_origins=["*"],


Changing CORS from specific origins to allow all origins (*) introduces a security risk. This allows any website to make requests to your API. Consider using environment variables to configure allowed origins for different deployment environments, or maintain the original restrictive list for production.

Copilot · 2025-12-01T13:50:03Z

application/backend/.pre-commit-config.yaml

+    rev: v2.12.0.2
+    hooks:
+      - id: hadolint
+        files: ^application/\.packaging/docker/ # TODO: this will break when the Dockerfile is moved


The TODO comment indicates technical debt. Consider using a more flexible file pattern (e.g., Dockerfile$ or **/*Dockerfile*) that won't break if the Dockerfile is moved, or create a tracking issue for this concern rather than leaving it as an inline TODO.

Suggested change

files: ^application/\.packaging/docker/ # TODO: this will break when the Dockerfile is moved

files: Dockerfile$|Dockerfile\..*$

application/.packaging/docker/docker-compose.yml

+      # Persist logs
+      - backend-logs:/app/logs
+    ports:
+      - "80:80"


application/backend/src/main.py

-        "http://localhost:9000",
-        "http://127.0.0.1:9000",
-    ],
+    allow_origins=["*"],


maxxgx · 2025-12-01T16:09:34Z

application/.packaging/docker/Dockerfile

+WORKDIR /app
+
+RUN --mount=type=cache,target=/home/non-root/.cache/uv,uid=10001,gid=10001 \
+    uv sync --frozen --no-dev --extra cpu --extra application


Why run uv sync from the root anomalib folder instead of application?

Installing inspect as an extra might be useful during development but I don't see the value in production environments

maxxgx · 2025-12-02T09:25:16Z

application/backend/src/api/endpoints/media_endpoints.py

Which pre-commit config did you run to result in all these style fixes? Using prek, ruff does not apply these changes.

maxxgx · 2025-12-02T09:30:47Z

application/backend/pyproject.toml

+[tool.hatch.build.targets.wheel.sources]
+"src" = ""


What does "src" = "" do?

* Replace "pre-commit" with "prek" in both root and application/backend pyproject.toml files. * Remove dependency for "geti-inspect" in the root pyproject.toml. Signed-off-by: Ashwin Vaidya <ashwin.vaidya@intel.com>

Signed-off-by: Ashwin Vaidya <ashwin.vaidya@intel.com>

Copilot

Pull request overview

Copilot reviewed 10 out of 13 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-03T13:17:18Z

application/backend/src/main.py

-        "http://localhost:9000",
-        "http://127.0.0.1:9000",
-    ],
+    allow_origins=["*"],


Allowing all origins with allow_origins=['*'] creates a security vulnerability by permitting cross-origin requests from any domain. This bypasses CORS protection and could enable malicious sites to access the API. Restrict allow_origins to specific trusted domains or use environment variables to configure allowed origins.

Copilot · 2025-12-03T13:17:18Z

application/.packaging/docker/README.md

+
+```bash
+cd application/.packaging/docker
+AI_DEVICE=cuda docker compose up


The device name 'cuda' is inconsistent with the docker-compose.yml and Dockerfile which use 'cu124'. Either update the example to use 'cu124' or ensure all references use 'cuda' consistently.

Suggested change

AI_DEVICE=cuda docker compose up

AI_DEVICE=cu124 docker compose up

Copilot · 2025-12-03T13:17:18Z

application/backend/pyproject.toml

    "paho-mqtt~=2.1.0",
 ]

+# Explicit versions are needed as we can't propogate extra dependencies to anomalib


Corrected spelling of 'propogate' to 'propagate'.

Suggested change

# Explicit versions are needed as we can't propogate extra dependencies to anomalib

# Explicit versions are needed as we can't propagate extra dependencies to anomalib

Signed-off-by: Ashwin Vaidya <ashwin.vaidya@intel.com>

Copilot

Pull request overview

Copilot reviewed 10 out of 13 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-03T13:26:03Z

application/.packaging/docker/docker-compose.yml

+    # Map all host devices to provide access to webcams and other attached devices
+    privileged: true
+    devices:
+      - /dev:/dev


Running the container in privileged mode with full access to /dev is a significant security risk that grants the container nearly unrestricted access to the host system. Consider mapping only specific required devices (e.g., /dev/video0 for webcams) and removing privileged: true unless absolutely necessary for the application's core functionality.

Suggested change

# Map all host devices to provide access to webcams and other attached devices

privileged: true

devices:

- /dev:/dev

# Map only required host devices (e.g., webcam) to the container for security.

# privileged: true # Removed for security; only enable if absolutely necessary.

# devices:

# - /dev/video0:/dev/video0 # Example: map only webcam device if needed.

warrkan · 2025-12-03T13:21:29Z

application/backend/src/main.py

-        "http://localhost:9000",
-        "http://127.0.0.1:9000",
-    ],
+    allow_origins=["*"],


I'd rather implement it via env variable: https://github.com/open-edge-platform/geti-prompt/blob/main/application/backend/app/main.py#L73

warrkan · 2025-12-03T13:22:25Z

application/backend/src/settings.py

    # Alembic
-    alembic_config_path: str = "src/alembic.ini"
-    alembic_script_location: str = "src/alembic"
+    alembic_config_path: str = str(_MODULE_DIR / "alembic.ini")


Should be adjusted further when we introduce Pyinstaller

warrkan · 2025-12-03T13:49:28Z

application/.packaging/docker/nginx.conf

@@ -0,0 +1,52 @@
+# PID file in a location non-root user can write to


Can we omit having nginx by serving UI static using FastAPI?

MarkRedeman and others added 30 commits October 8, 2025 13:52

Initial UI setup for Geti Inspect

5bdd704

Mainly based on the UI files and architecture from [Geti Tune](https://github.com/open-edge-platform/training_extensions/tree/develop/ui)

🧪 test(get-inspect): add unit tests for endpoints (open-edge-platform…

82dd6b0

…#2942) add unit tests for endpoints Signed-off-by: Ma, Xiangxiang <xiangxiang.ma@intel.com>

Add openapi spec to gitignore

1588d72

Use error page

22f8f8f

Delete nginx and Dockerfile

978a895

These won't be needed yet

🔧 chore(geti-inspect): Update Geti Inspect to react 19 (open-edge-pla…

cbb0a46

…tform#2948) * Use src folder inside run.sh * Set openapi_url path * Update to react 19 * Specify bash language in readme

🔧 chore(inspect): Update route structure and add openapi route (open-…

0614756

…edge-platform#2963) * Add OpenAPI route * Remove MSW browser worker * Rename infernece to inspect * Update navbar title * Rename infernece to inspect

chore: Update package lock (open-edge-platform#2967)

e07a955

feat: Add sidebar with dataset, models and stats (open-edge-platform#…

e04ef66

…2970) * chore: Add path alias to icons * feat: Add sidebar with dataset, models and stats

🚀 feat(inspect): Add dataset list (open-edge-platform#2971)

3489422

* feat: Display placeholders for images * refactor: Fix scrollbar * chore: Remove learn more

🔧 chore(inspect): Update UI scripts (open-edge-platform#2974)

4e160a1

* chore(inspect): Update UI scripts * chore: Update github actions * chore: Update port to 8000

🔧 chore(inspect): Configure project(s) mocks for playwright tests (op…

7437855

…en-edge-platform#2978) chore(inspect): Configure project(s) mocks for playwright

🚀 feat(inspect): Add project management (open-edge-platform#2977)

590ece3

* chore: Add project route * feat: Add project management * revert ui lock change * chore: Remove not needed code for project management

🔧 chore(inspect): Update allowed origins so server can receive reques…

d9a613d

…ts from the UI (open-edge-platform#2980) chore(inspect): Update allowed origins

🔧 chore(inspect): Update openapi page (open-edge-platform#2985)

1baa2eb

chore(inspect): Update openapi page title

🔧 chore(inspect): Rename folder structure from app to application (op…

0a2af70

…en-edge-platform#2989) * chore(inspect): Renamed app to application * chore(inspect): Rename app to application in github actions

refactor(inspect): Update photo placeholder to use indicator instead …

8f1ef19

…of email (open-edge-platform#2990) refactor: Update photo placeholder to use indicator instead of email

Fix path (open-edge-platform#2993)

237731d

Signed-off-by: Ashwin Vaidya <ashwin.vaidya@intel.com>

🔄 refactor(inspect): Improvements to the jobs management and training (…

2a4f257

…open-edge-platform#2992) refactor: Improvements to the jobs management and training

🔧 chore(inspect): Add more models to be used for training (open-edge-…

7653915

…platform#2994) chore(inspect): Add more models

🐛 fix(inspect): Use null pool for async engine (open-edge-platform#2998)

f0a7643

🐛 fix(inspect): Fix unable to start train job

🔧 chore(inspect): Update uv.lock (open-edge-platform#2995)

df8eb42

chore(inspect): Update uv.lock

Comment XPU settings

438a499

Signed-off-by: Ashwin Vaidya <ashwin.vaidya@intel.com>

ashwinvaidya17 marked this pull request as ready for review November 28, 2025 08:52

ashwinvaidya17 requested review from MarkRedeman, maxxgx, rajeshgangireddy and samet-akcay as code owners November 28, 2025 08:52

ashwinvaidya17 added 2 commits December 1, 2025 14:45

Merge branch 'feature/geti-inspect' into ashwin/feature/dockerfile_2

70f05fa

Merge branch 'feature/geti-inspect' into ashwin/feature/dockerfile_2

39209fc

Copilot AI review requested due to automatic review settings December 1, 2025 13:48

Copilot AI reviewed Dec 1, 2025

View reviewed changes

github-advanced-security bot found potential problems Dec 1, 2025

View reviewed changes

maxxgx reviewed Dec 1, 2025

View reviewed changes

maxxgx reviewed Dec 2, 2025

View reviewed changes

ashwinvaidya17 added 6 commits December 2, 2025 15:37

chore: update dependencies in pyproject.toml

5cf0ad6

* Replace "pre-commit" with "prek" in both root and application/backend pyproject.toml files. * Remove dependency for "geti-inspect" in the root pyproject.toml. Signed-off-by: Ashwin Vaidya <ashwin.vaidya@intel.com>

Update prek references

83a7c16

Signed-off-by: Ashwin Vaidya <ashwin.vaidya@intel.com>

Update uv.lock

85d4860

Signed-off-by: Ashwin Vaidya <ashwin.vaidya@intel.com>

update dockerfile

54501fb

Signed-off-by: Ashwin Vaidya <ashwin.vaidya@intel.com>

Merge branch 'feature/geti-inspect' into ashwin/feature/dockerfile_2

5d3a63c

Revert formatting

bdac68a

Signed-off-by: Ashwin Vaidya <ashwin.vaidya@intel.com>

Copilot AI review requested due to automatic review settings December 3, 2025 13:16

Copilot AI reviewed Dec 3, 2025

View reviewed changes

ashwinvaidya17 added 3 commits December 3, 2025 14:17

Revert formatting

3af24ca

Signed-off-by: Ashwin Vaidya <ashwin.vaidya@intel.com>

Update actions

0e450d1

Signed-off-by: Ashwin Vaidya <ashwin.vaidya@intel.com>

fix typo

86e137a

Signed-off-by: Ashwin Vaidya <ashwin.vaidya@intel.com>

ashwinvaidya17 requested review from AlexanderBarabanov and mramotowski as code owners December 3, 2025 13:24

Copilot AI review requested due to automatic review settings December 3, 2025 13:25

Copilot AI reviewed Dec 3, 2025

View reviewed changes

warrkan reviewed Dec 3, 2025

View reviewed changes

	files: ^application/\.packaging/docker/ # TODO: this will break when the Dockerfile is moved
	files: Dockerfile$\|Dockerfile\..*$

	AI_DEVICE=cuda docker compose up
	AI_DEVICE=cu124 docker compose up

	# Explicit versions are needed as we can't propogate extra dependencies to anomalib
	# Explicit versions are needed as we can't propagate extra dependencies to anomalib

		@@ -0,0 +1,52 @@
		# PID file in a location non-root user can write to

		[tool.hatch.build.targets.wheel.sources]
		"src" = ""

📦 feat(inspect): Add docker build #3136

Are you sure you want to change the base?

📦 feat(inspect): Add docker build #3136

Uh oh!

Conversation

ashwinvaidya17 commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Description

TODO

✨ Changes

✅ Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Check warning

Check warning

maxxgx Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

maxxgx Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

maxxgx Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

warrkan Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

warrkan Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

warrkan Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ashwinvaidya17 commented Nov 21, 2025 •

edited

Loading