fix: Fix power energy threshold related tests #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related-To: VLCLJ-2648 Signed-off-by: Anvesh Bakwad <anvesh.bakwad@intel.com>
aviralni
reviewed
Dec 2, 2025
| EXPECT_LT(pThreshold.processId, UINT32_MAX); | ||
| else | ||
| EXPECT_EQ(pThreshold.processId, UINT32_MAX); | ||
| EXPECT_LT(pThreshold.processId, UINT32_MAX); |
Contributor
There was a problem hiding this comment.
If threshold has not been set, then this processId will be UINT32_MAX.
Contributor
Author
There was a problem hiding this comment.
used EXPECT_LE() now.
Contributor
There was a problem hiding this comment.
Can we specifically check this condition
"
If threshold has not been set, then this processId will be UINT32_MAX."
Related-To: VLCLJ-2648 Signed-off-by: Anvesh Bakwad <anvesh.bakwad@intel.com>
anvesh-intel
commented
Dec 2, 2025
| } | ||
| LZT_TEST_F( | ||
| POWER_TEST, | ||
| GivenValidPowerHandleWhenGettingEnergyThresholdThenSuccessIsReturnedAndParameterValuesAreValid) { |
Contributor
Author
There was a problem hiding this comment.
@joshuaranjan Is this test needed now as we're deprecating the support of zesPowerGetEnergyThreshold() API as mentioned in https://docs.intel.com/documents/GfxSWAT/Common/sysman/SysmanAPI.html#power ?
Contributor
There was a problem hiding this comment.
Hi Anvesh, this needs to be supported for platforms till CRI.
So lets add the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related-To: VLCLJ-2648
Signed-off-by: Anvesh Bakwad anvesh.bakwad@intel.com