Skip to content

Conversation

@kashifo
Copy link

@kashifo kashifo commented Dec 2, 2024

I have added an option to show upvotes and answers as well, these are important metrics too and there was empty space in default UI card.
And I have not touched any of your existing code, This new option works only with a parameter, and I have tested it as well, So it's 100% safe for you to merge it.

Please merge it and make me a contributor in your open-source project.

Appreciate you and your work!

Here's a screenshot of how it looks:
Screenshot from 2024-12-02 23-42-41

@vercel
Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
github-readme-stackoverflow-ltfi ❌ Failed (Inspect) Dec 2, 2024 6:17pm

@vercel
Copy link

vercel bot commented Dec 2, 2024

@kashifo is attempting to deploy a commit to the Omid Nikrah's projects Team on Vercel.

A member of the Team first needs to authorize it.

@kashifo
Copy link
Author

kashifo commented Dec 2, 2024

Updated vercel.json to support latest version of Vercel.
I've deployed on my own Vercel instance, and it worked 100% fine, below is an example, So now feel 200% safe to merge it.

Kashif's StackOverflow

@kashifo
Copy link
Author

kashifo commented Dec 15, 2024

@omidnikrah Could you please accept my changes (you can leave the last commit - that's accidentally requested for pull)
If you don't want to merge my changes, please tell me why.

Thanks.


<p align="center">
<img width="120px" src="https://raw.githubusercontent.com/omidnikrah/github-readme-stackoverflow/master/stackoverflow.svg" />
<img width="120px" src="https://raw.githubusercontent.com/kashifo/github-readme-stackoverflow/master/stackoverflow.svg" />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert all the usernames and userIDs to what is in the README file.

</svg>
`;
} else if (layout === 'full') {
return `
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please DO NOT generate the whole card again for the full layout, only add those extra data if the layout is full.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants