Add weather-app module for fetching city temperatures

[omar-coderabbitai]

@coderabbitai

Summary by CodeRabbit

Release Notes

• New Features
  • Users can now retrieve current temperatures for major US cities via weather data integration
  • Application includes input validation and error handling to ensure reliable results and graceful handling of API or network issues

[coderabbitai]

Walkthrough

A new weather-app.py module adds functionality to fetch current temperatures for US cities via the OpenWeatherMap API. It includes a get_temperature() function with input validation and error handling, a main() orchestrator, and comprehensive unit tests covering success scenarios, HTTP errors, network failures, and JSON parsing edge cases.

Changes

Cohort / File(s)

Summary

Weather Application Module weather-app.py

Adds get_temperature(city_name, api_key) function for fetching Fahrenheit temperatures with robust error handling (HTTP errors, connection issues, timeouts, JSON parsing). Adds main() orchestrator for environment variable retrieval, user input validation, and formatted output. Includes comprehensive unittest suite with mocked external interactions (requests, env vars, input, prints) validating 10+ scenarios including API key validity, network errors, and main flow paths.

Sequence Diagram

sequenceDiagram
    participant User
    participant main
    participant get_temperature
    participant OpenWeatherMap API
    
    User->>main: Run program
    main->>main: Retrieve OPENWEATHER_API_KEY from env
    main->>User: Prompt for city name
    User->>main: Enter city
    main->>main: Validate city input
    main->>get_temperature: Call with city & api_key
    
    alt Valid Request
        get_temperature->>OpenWeatherMap API: HTTP GET request
        OpenWeatherMap API-->>get_temperature: JSON response
        get_temperature->>get_temperature: Parse & extract temperature
        get_temperature-->>main: Return temperature (float)
        main->>User: Print formatted result
    else Error Occurs
        get_temperature-->>get_temperature: Handle error (HTTP, network, parse)
        get_temperature-->>main: Return None
        main->>User: Print error message
    end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

• Review get_temperature() function for comprehensive error handling across multiple failure modes (HTTP status codes, connection errors, timeouts, JSON parsing)
• Verify input validation logic for API key (None, empty, non-string) and city name handling
• Examine unittest suite structure and mocking approach to ensure all external interactions are properly isolated
• Validate that all exception types are caught and handled appropriately
• Confirm environment variable retrieval and user prompt flow in main()

Poem

🐰 Whiskers twitching with delight,
A weather app takes flight!
Through OpenWeather's API we hop,
Fetching temps without a stop!
With tests and mocks so neat and tight,
This rainy code feels just right! ☀️

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title '@coderabbitai' is unrelated to the changeset, which implements a weather app module with temperature fetching and comprehensive tests.	Replace the title with a descriptive summary of the main change, such as 'Add weather app module with OpenWeatherMap API integration and unit tests'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Unit Test Coverage	✅ Passed	The pull request includes comprehensive unit test coverage with tests for API success cases, API key validation, HTTP errors, network errors, exception handling, and multiple main flow scenarios, with all external interactions properly mocked.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch og-test-feature

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b534b4b and 707ef30.

📒 Files selected for processing (1)

• weather-app.py (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**/**

⚙️ CodeRabbit configuration file

**/**: - Only comment on issues that would block merging — ignore minor or stylistic concerns.

• Restrict feedback to errors, security risks, or functionality-breaking problems.
• Do not post comments on code style, formatting, or non-critical improvements.
• Keep reviews short: flag only issues that make the PR unsafe to merge.
• Limit review comments to 3–5 items maximum, unless additional blockers exist.
• Group similar issues into a single comment instead of posting multiple notes.
• Skip repetition — if a pattern repeats, mention it once at a summary level only.
• Do not add general suggestions, focus strictly on merge-blocking concerns.
• If there are no critical problems, respond with minimal approval (e.g., 'Looks good'). Do not add additional review.
• Avoid line-by-line commentary unless it highlights a critical bug or security hole.
• Highlight only issues that could cause runtime errors, data loss, or severe maintainability
  issues.
• Ignore minor optimization opportunities — focus solely on correctness and safety.
• Provide a top-level summary of critical blockers rather than detailed per-line notes.
• Comment only when the issue must be resolved before merge — otherwise remain silent.
• When in doubt, err on the side of fewer comments — brevity and blocking issues only.
• Avoid posting any refactoring issues

Files:

• weather-app.py

🪛 Ruff (0.14.3)

weather-app.py

75-75: Expected 'import', found '-'

(invalid-syntax)

---

75-75: Simple statements must be separated by newlines or semicolons

(invalid-syntax)

[coderabbitai]

⚠️ Potential issue | 🔴 Critical

CRITICAL: Module name contains hyphen causing import syntax errors.

The filename weather-app.py cannot be imported in Python because hyphens are invalid in module names. Line 75 (from weather-app import) and all @patch('weather-app.*') decorators throughout the tests will fail with syntax errors.

Rename the file to use an underscore:

-# filename: weather-app.py
+# filename: weather_app.py

Then update line 75:

-from weather-app import get_temperature, main
+from weather_app import get_temperature, main

And update all patch decorators (lines 81, 101, 111, 121, 131, 145, 159, 170, 181, 193, 207, 221, 239, 256, 267, 279, 294):

-@patch('weather-app.requests.get')
+@patch('weather_app.requests.get')

-@patch('weather-app.get_temperature')
+@patch('weather_app.get_temperature')

-@patch('weather-app.os.getenv')
+@patch('weather_app.os.getenv')

Committable suggestion skipped: line range outside the PR's diff.

🧰 Tools

🪛 Ruff (0.14.3)

75-75: Expected 'import', found '-'

(invalid-syntax)

---

75-75: Simple statements must be separated by newlines or semicolons

(invalid-syntax)

🤖 Prompt for AI Agents

In weather-app.py around line 75, the module name contains a hyphen which is
invalid for Python imports; rename the file to weather_app.py, update the import
at line 75 from "from weather-app import ..." to "from weather_app import ..."
and update every @patch decorator that references "weather-app.*" to use
"weather_app.*" on lines 81, 101, 111, 121, 131, 145, 159, 170, 181, 193, 207,
221, 239, 256, 267, 279, and 294; also search the repo for any other imports or
references to weather-app and change them to weather_app (including test
fixtures, setup files, and any relative imports).