Refactor code for improved quality #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add TEXTAREA_CONFIG for textarea auto-resize parameters - Add EXPORT_FORMAT for JSON export configuration - Add PRICING_MULTIPLIERS for model pricing calculations - Add TOAST_CONFIG for toast notification settings - Update TranslationEditor to use TEXTAREA_CONFIG - Update FileManager to use EXPORT_FORMAT - Update ModelSelector to use PRICING_MULTIPLIERS - Update App to use TOAST_CONFIG This improves maintainability by centralizing configuration values and makes it easier to adjust settings in the future.
- Add pathUtils for parsing variation paths (type:key format) - Add modelUtils for extracting and formatting provider names - Update FileManager to use parsePathPart utility - Update variationUtils to use parsePathPart utility - Update ModelSelector to use extractProviderFromModelId and capitalizeProvider This reduces code duplication and makes path parsing logic reusable across the codebase. The pattern "type:key" splitting now has a single source of truth.
- Create pricingUtils with formatModelPricing function - Remove 54 lines of duplicate pricing logic from ModelSelector - Support both detailed and compact pricing formats - Improve maintainability by centralizing pricing calculations This eliminates the exact same pricing calculation that appeared twice in ModelSelector (lines 97-111 and 138-151).
- Create config/env.ts with environment configuration - Add API_ENDPOINTS for CHAT_COMPLETIONS and MODELS - Update translationService to use API_ENDPOINTS - Update modelService to use API_ENDPOINTS - Support VITE_OPENROUTER_API_URL environment variable This makes it easy to: - Switch between environments (dev/staging/prod) - Mock API endpoints for testing - Configure self-hosted OpenRouter instances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.