Skip to content

[IMP] devtools: copy component name to clipboard #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+27 −2
Open

[IMP] devtools: copy component name to clipboard #1708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...evtools/src/devtools_app/devtools_window/components_tab/details_window/details_window.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,13 @@
<div class="panel-top d-flex align-items-center">
<div class="ms-1 p-1 text-truncate" style="width: 100%;">
<span t-if="store.activeComponent.path.length > 1">&lt;</span>
<b style="color: var(--component-color); cursor: pointer;" t-on-mouseover.stop="() => this.store.highlightComponent(this.store.activeComponent.path)" t-on-click.stop="() => this.store.focusSelectedComponent()" t-on-contextmenu.prevent="openMenu" t-esc="store.activeComponent.name"/>
<b
style="color: var(--component-color); cursor: pointer;"
t-on-mouseover.stop="() => this.store.highlightComponent(this.store.activeComponent.path)"
t-on-click.stop="() => this.store.onActiveComponentClick()"
t-on-contextmenu.prevent="openMenu"
t-esc="store.activeComponent.name"
/>
<span t-if="store.activeComponent.path.length > 1">&gt;</span>
<span class="version" t-else="">owl=<t t-esc="store.activeComponent.version"/></span>
</div>
Expand Down
21 changes: 20 additions & 1 deletion tools/devtools/src/devtools_app/store/store.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,8 +608,9 @@ export const store = reactive({
},

// Center the view around the currently selected component
focusSelectedComponent() {
onActiveComponentClick() {
this.selectedElement.scrollIntoView({ block: "center", behavior: "smooth" });
copyToClipboard(this.activeComponent.name);
},

// Toggle the recording of events in the page
Expand Down Expand Up @@ -1055,3 +1056,21 @@ async function evalInWindow(code, frameUrl = "top") {
}
});
}

function copyToClipboard(text) {
// This is crappy but it seems like document.execCommand is the only remaining way to
// copy text to clipboard in a devtools extension (even though it is marked as deprecated)
// since navigator.clipboard.writeText has permission issues inside iframes (and the devtools
// panel is mounted inside an iframe)
const textarea = document.createElement("textarea");
textarea.value = text;
textarea.style.opacity = "0";
document.body.appendChild(textarea);
textarea.select();
try {
document.execCommand("copy");
} catch (err) {
console.error("Copy failed", err);
}
document.body.removeChild(textarea);
}