Skip to content

Add more visibility about the sent status of invoice #4878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 18.0-rd-accounting-onboarding-malb
Choose a base branch
from
Open

Add more visibility about the sent status of invoice #4878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions addons/account/models/account_move.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,6 +614,13 @@ def _sequence_year_range_monthly_regex(self):
tracking=True,
help="It indicates that the invoice/payment has been sent or the PDF has been generated.",
)
move_sent_selection = fields.Selection(
selection=[
('sent', 'Sent'),
('not_sent', 'Not Sent'),
],
compute='compute_move_sent_selection',
)
is_being_sent = fields.Boolean(
help="Is the move being sent asynchronously",
compute='_compute_is_being_sent'
Expand Down Expand Up @@ -848,6 +855,11 @@ def _get_valid_journal_types(self):
elif self.origin_payment_id or self.statement_line_id or self.env.context.get('is_payment') or self.env.context.get('is_statement_line'):
return ['bank', 'cash', 'credit']
return ['general']

@api.depends('is_move_sent')
def compute_move_sent_selection(self):
for move in self:
move.move_sent_selection = 'sent' if move.is_move_sent else 'not_sent'

def _search_default_journal(self):
if self.statement_line_ids.statement_id.journal_id:
Expand Down
13 changes: 12 additions & 1 deletion addons/account/views/account_move_views.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,6 +549,12 @@
invisible="payment_state == 'invoicing_legacy' or move_type == 'entry'"
optional="show"
/>
<field name="move_sent_selection"
widget="badge"
string="Sent"
decoration-success="move_sent_selection == 'sent'"
decoration-danger="move_sent_selection == 'not_sent'"
optional="hide"/>
<field name="move_type" column_invisible="context.get('default_move_type', True)"/>
<field name="abnormal_amount_warning" column_invisible="1"/>
<field name="abnormal_date_warning" column_invisible="1"/>
Expand Down Expand Up @@ -1595,10 +1601,15 @@
groups="account.group_account_secured,base.group_no_one"/>
<separator/>
<filter name="not_sent"
string="Not Sent"
string="Not Sent invoices"
domain="[('is_move_sent', '=', False)]"
invisible="context.get('default_move_type') in ('in_invoice', 'in_refund', 'in_receipt')"
/>
<filter name="sent"
string="Sent invoices"
domain="[('is_move_sent', '=', True)]"
invisible="context.get('default_move_type') in ('in_invoice', 'in_refund', 'in_receipt')"
/>
<separator/>
<filter name="out_invoice"
string="Invoices"
Expand Down