perf containerNode => search in descendents / children

Author: Gorash

packages/core/src/VNodes/ContainerNode.ts

@@ -4,7 +4,6 @@ import { ChildError } from '../../../utils/src/errors';
 import { VersionableArray } from '../Memory/VersionableArray';
 
 export class ContainerNode extends AbstractNode {
-    parent: ContainerNode;
     readonly childVNodes: VNode[] = new VersionableArray<VNode>();
 
     //--------------------------------------------------------------------------
@@ -17,15 +16,19 @@ export class ContainerNode extends AbstractNode {
     children<T extends VNode>(predicate?: Predicate<T>): T[];
     children(predicate?: Predicate): VNode[];
     children(predicate?: Predicate): VNode[] {
-        return this.childVNodes.filter(child => {
-            return child.tangible && child.test(predicate);
+        const children: VNode[] = [];
+        this.childVNodes.forEach(child => {
+            if (child.tangible && (!predicate || child.test(predicate))) {
+                children.push(child);
+            }
         });
+        return children;
     }
     /**
      * See {@link AbstractNode.hasChildren}.
      */
     hasChildren(): boolean {
-        return this.children().length > 0;
+        return !!this.childVNodes.find(child => child.tangible);
     }
     /**
      * See {@link AbstractNode.nthChild}.
@@ -40,7 +43,7 @@ export class ContainerNode extends AbstractNode {
     firstChild(predicate?: Predicate): VNode;
     firstChild(predicate?: Predicate): VNode {
         let child = this.childVNodes[0];
-        while (child && !(child.tangible && child.test(predicate))) {
+        while (child && !(child.tangible && (!predicate || child.test(predicate)))) {
             child = child.nextSibling();
         }
         return child;
@@ -52,7 +55,7 @@ export class ContainerNode extends AbstractNode {
     lastChild(predicate?: Predicate): VNode;
     lastChild(predicate?: Predicate): VNode {
         let child = this.childVNodes[this.childVNodes.length - 1];
-        while (child && !(child.tangible && child.test(predicate))) {
+        while (child && !(child.tangible && (!predicate || child.test(predicate)))) {
             child = child.previousSibling();
         }
         return child;
@@ -64,7 +67,7 @@ export class ContainerNode extends AbstractNode {
     firstLeaf(predicate?: Predicate): VNode;
     firstLeaf(predicate?: Predicate): VNode {
         const isValidLeaf = (node: VNode): boolean => {
-            return isLeaf(node) && node.test(predicate);
+            return isLeaf(node) && (!predicate || node.test(predicate));
         };
         if (isValidLeaf(this)) {
             return this;
@@ -79,7 +82,7 @@ export class ContainerNode extends AbstractNode {
     lastLeaf(predicate?: Predicate): VNode;
     lastLeaf(predicate?: Predicate): VNode {
         const isValidLeaf = (node: VNode): boolean => {
-            return isLeaf(node) && node.test(predicate);
+            return isLeaf(node) && (!predicate || node.test(predicate));
         };
         if (isValidLeaf(this)) {
             return this;
@@ -94,7 +97,7 @@ export class ContainerNode extends AbstractNode {
     firstDescendant(predicate?: Predicate): VNode;
     firstDescendant(predicate?: Predicate): VNode {
         let firstDescendant = this.firstChild();
-        while (firstDescendant && !firstDescendant.test(predicate)) {
+        while (firstDescendant && predicate && firstDescendant.test(predicate)) {
             firstDescendant = this._descendantAfter(firstDescendant);
         }
         return firstDescendant;
@@ -109,7 +112,7 @@ export class ContainerNode extends AbstractNode {
         while (lastDescendant && lastDescendant.hasChildren()) {
             lastDescendant = lastDescendant.lastChild();
         }
-        while (lastDescendant && !lastDescendant.test(predicate)) {
+        while (lastDescendant && predicate && !lastDescendant.test(predicate)) {
             lastDescendant = this._descendantBefore(lastDescendant);
         }
         return lastDescendant;
@@ -124,7 +127,7 @@ export class ContainerNode extends AbstractNode {
         const stack = [...this.childVNodes];
         while (stack.length) {
             const node = stack.shift();
-            if (node.tangible && node.test(predicate)) {
+            if (node.tangible && (!predicate || node.test(predicate))) {
                 descendants.push(node);
             }
             if (node instanceof ContainerNode) {
@@ -227,9 +230,11 @@ export class ContainerNode extends AbstractNode {
             return this;
         }
         const duplicate = this.clone();
-        const index = child.parent.childVNodes.indexOf(child);
-        while (this.childVNodes.length > index) {
-            duplicate.append(this.childVNodes[index]);
+        const index = this.childVNodes.indexOf(child);
+        const children = this.childVNodes.splice(index);
+        duplicate.childVNodes.push(...children);
+        for (const child of children) {
+            child.parent = duplicate;
         }
         this.after(duplicate);
         return duplicate;