perf: inline getCurrentStyle => change selection, insert new char

Author: Gorash

packages/plugin-char/src/Char.ts

@@ -50,10 +50,13 @@ export class Char<T extends JWPluginConfig = JWPluginConfig> extends JWPlugin<T>
         let modifiers = inline.getCurrentModifiers(range);
         // Ony preserved modifiers are applied at the start of a container.
         const previousSibling = range.start.previousSibling();
-        if (!previousSibling) {
+        if (!previousSibling && modifiers) {
             modifiers = new Modifiers(...modifiers.filter(mod => mod.preserve));
         }
         if (params.formats) {
+            if (!modifiers) {
+                modifiers = new Modifiers();
+            }
             modifiers.set(...params.formats.map(format => format.clone()));
         }
         const style = inline.getCurrentStyle(range);
@@ -64,17 +67,20 @@ export class Char<T extends JWPluginConfig = JWPluginConfig> extends JWPlugin<T>
         // Split the text into CHAR nodes and insert them at the range.
         const characters = text.split('');
         const charNodes = characters.map(char => {
-            return new CharNode({ char: char, modifiers: modifiers.clone() });
+            if (modifiers) {
+                return new CharNode({ char: char, modifiers: modifiers.clone() });
+            } else {
+                return new CharNode({ char: char });
+            }
         });
         charNodes.forEach(charNode => {
-            if (style.length) {
+            if (style?.length) {
                 charNode.modifiers.get(Attributes).style = style;
             }
             range.start.before(charNode);
         });
         if (params.select && charNodes.length) {
             this.editor.selection.select(charNodes[0], charNodes[charNodes.length - 1]);
         }
-        inline.resetCache();
     }
 }

packages/plugin-inline/src/Inline.ts

@@ -125,7 +125,7 @@ export class Inline<T extends JWPluginConfig = JWPluginConfig> extends JWPlugin<
     isAllFormat(FormatClass: Constructor<Modifier>, range = this.editor.selection.range): boolean {
         if (range.isCollapsed()) {
             if (!this.cache.modifiers) {
-                return !!this.getCurrentModifiers(range).find(FormatClass);
+                return !!this.getCurrentModifiers(range)?.find(FormatClass);
             }
             return !!this.cache.modifiers.find(FormatClass);
         } else {
@@ -139,30 +139,44 @@ export class Inline<T extends JWPluginConfig = JWPluginConfig> extends JWPlugin<
     /**
      * Get the modifiers for the next insertion.
      */
-    getCurrentModifiers(range = this.editor.selection.range): Modifiers {
-        if (this.cache.modifiers) {
+    getCurrentModifiers(range = this.editor.selection.range): Modifiers | null {
+        if (this.cache.modifiers && range === this.editor.selection.range) {
             return this.cache.modifiers;
+        } else {
+            return this._getCurrentModifiers(range);
         }
-
+    }
+    /**
+     * Get the current modifiers.
+     */
+    private _getCurrentModifiers(range = this.editor.selection.range): Modifiers | null {
         let inlineToCopyModifiers: VNode;
         if (range.isCollapsed()) {
             // TODO: LineBreakNode should have the formats as well.
             inlineToCopyModifiers =
-                range.start.previousSibling(node => !node.test(LineBreakNode)) ||
+                range.start.previousSibling(node => !(node instanceof LineBreakNode)) ||
                 range.start.nextSibling();
         } else {
             inlineToCopyModifiers = range.start.nextSibling();
         }
         if (inlineToCopyModifiers && inlineToCopyModifiers.is(InlineNode)) {
             return inlineToCopyModifiers.modifiers.clone();
         }
-
-        return new Modifiers();
     }
     /**
      * Get the styles for the next insertion.
      */
-    getCurrentStyle(range = this.editor.selection.range): CssStyle {
+    getCurrentStyle(range = this.editor.selection.range): CssStyle | null {
+        if (this.cache.style && range === this.editor.selection.range) {
+            return this.cache.style;
+        } else {
+            return this._getCurrentStyle(range);
+        }
+    }
+    /**
+     * Get the current styles for the next insertion.
+     */
+    private _getCurrentStyle(range = this.editor.selection.range): CssStyle | null {
         if (this.cache.style) {
             return this.cache.style;
         }
@@ -176,15 +190,14 @@ export class Inline<T extends JWPluginConfig = JWPluginConfig> extends JWPlugin<
         if (inlineToCopyStyle && inlineToCopyStyle.is(InlineNode)) {
             return inlineToCopyStyle.modifiers.find(Attributes)?.style.clone() || new CssStyle();
         }
-        return new CssStyle();
     }
     /**
      * Each time the selection changes, we reset its format and style.
      */
     resetCache(): void {
         this.cache = {
-            modifiers: null,
-            style: null,
+            modifiers: this._getCurrentModifiers(),
+            style: this._getCurrentStyle(),
         };
     }
     /**