This repository was archived by the owner on Aug 30, 2024. It is now read-only.
Add travis support #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Sonar is mostly complaining I think due to not having enough coverage yet. Been meaning to get back and add more coverage. And you're welcome! Glad you like it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this project, I see there are tests, but they're not automated so here we go.
Passing on the first run 🎉.
Edit: oh, nevermind, I see you're using sonarcloud. And you're using something on AWS side to run the tests. I'm not quite sure why sonarcloud marks as failed tho. Your tests are passing according to travis:
https://travis-ci.com/GabLeRoux/node-acme-lambda