[str replace] add exemple for escaped regexes #14038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdncred
reviewed
Oct 9, 2024
quadristan
force-pushed
the
ex-replace-escaped
branch
from
154ffee to
555c7eb
Compare
quadristan
force-pushed
the
ex-replace-escaped
branch
from
555c7eb to
ec8ccd4
Compare
Contributor
|
Thanks |
fdncred
added
the
deprecated:pr-commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up of nushell/nushell.github.io#1584
The goal is to provide the user understanding of how to escape strings
User-Facing Changes
Nothing except documentation
Tests + Formatting
I don't know why but these two tests are failing on my system:
test_std_util path_addcommands::umkdir::mkdir_umask_permissionSince I hardly believe it is linked to my changes, I will let your CI check it. Meanwhile, I will check my system, highly likely that it is something something related to me recently switching shells, hacking my way through prompts environments, etc.
After Submitting
Will check how to re-generate the the documentation after the PR is merged