Change wrap example in merge.md
#1571
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the example to make it clearer
Contributor
|
Right, ci. You can't change the merge help because it's auto generated from the rust code and docs are updated upon each release. If you want to change the help for merge, you must change the rust code for merge. Thanks. |
Author
|
Oh okay, sorry for the noise. |
Contributor
|
no worries at all. thanks for trying to help. |
Contributor
|
@AlifianK Great suggestion - Thank you! I went ahead and made the change in the main repo with credit to you. I know if you don't have the Rust toolchain set up already, it's a bit overkill to have to do so just to make this change. |
IanManske
pushed a commit
to nushell/nushell
that referenced
this pull request
Oct 2, 2024
# Description All credit to @AlifianK for suggesting this in the doc repo (nushell/nushell.github.io#1571). This updates the merge example to make it more clear by using a different set of numbers that can't easily be confused with an `index`. Also changes the `index` to `id` to remove the "magic column name conversion". (#13780). # User-Facing Changes Help/Doc change only # Tests + Formatting - 🟢 `toolkit fmt` - 🟢 `toolkit clippy` - 🟢 `toolkit test` - 🟢 `toolkit test stdlib` # After Submitting N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the example to make it clearer