Speed up test suite runtime

Instead of creating the project directory on every run, we only really
need the package.json written each time. (And to clear out both the
package.json and the .node-version files)

Author: jasonkarns

test/nodenv-package-json-engine.bats

@@ -4,7 +4,7 @@ load test_helper
 
 @test 'Recognizes simple node version specified in package.json engines' {
   with_installed_node_versions 4.2.1
-  cd_into_package 4.2.1
+  in_package_for_engine 4.2.1
 
   run nodenv version
   assert_success '4.2.1 (set by package-json-engine matching 4.2.1)'
@@ -14,23 +14,23 @@ load test_helper
 
 @test 'Recognizes a semver range matching an installed version' {
   with_installed_node_versions 4.2.1
-  cd_into_package '>= 4.0.0'
+  in_package_for_engine '>= 4.0.0'
 
   run nodenv version
   assert_success '4.2.1 (set by package-json-engine matching >= 4.0.0)'
 }
 
 @test 'Prefers the greatest installed version matching a range' {
   with_installed_node_versions 4.0.0 4.2.1
-  cd_into_package '^4.0.0'
+  in_package_for_engine '^4.0.0'
 
   run nodenv version
   assert_success '4.2.1 (set by package-json-engine matching ^4.0.0)'
 }
 
 @test 'Ignores non-matching installed versions' {
   with_installed_node_versions 0.12.7
-  cd_into_package '>= 4.0.0'
+  in_package_for_engine '>= 4.0.0'
 
   # For unknown reasons, nodenv-version succeeds when version-name fails,
   # so we're testing version-name directly
@@ -46,7 +46,7 @@ load test_helper
 
 @test 'Prefers nodenv-local over package.json' {
   with_installed_node_versions 4.2.1 5.0.0
-  cd_into_package 4.2.1
+  in_package_for_engine 4.2.1
   nodenv local 5.0.0
 
   run nodenv version
@@ -55,7 +55,7 @@ load test_helper
 
 @test 'Prefers nodenv-shell over package.json' {
   with_installed_node_versions 5.0.0
-  cd_into_package 4.2.1
+  in_package_for_engine 4.2.1
   eval "$(nodenv sh-shell 5.0.0)"
 
   run nodenv version
@@ -64,7 +64,7 @@ load test_helper
 
 @test 'Prefers package.json over nodenv-global' {
   with_installed_node_versions 4.2.1 5.0.0
-  cd_into_package 4.2.1
+  in_package_for_engine 4.2.1
   nodenv global 5.0.0
 
   run nodenv version-name
@@ -73,7 +73,7 @@ load test_helper
 
 @test 'Is not confused by nodenv-shell shadowing nodenv-global' {
   with_installed_node_versions 4.2.1 5.0.0
-  cd_into_package 4.2.1
+  in_package_for_engine 4.2.1
   nodenv global 5.0.0
   eval "$(nodenv sh-shell 5.0.0)"
 

test/test_helper.bash

@@ -2,6 +2,9 @@
 
 load ../node_modules/bats-assert/all
 
+EXAMPLE_PACKAGE_DIR="$BATS_TMPDIR/example_package"
+mkdir -p "$EXAMPLE_PACKAGE_DIR"
+
 setup() {
   # common nodenv setup
   unset NODENV_VERSION
@@ -11,34 +14,27 @@ setup() {
   export PATH="$node_modules_bin:/usr/bin:/bin:/usr/sbin:/sbin"
 
   export NODENV_ROOT="$BATS_TEST_DIRNAME/fixtures/nodenv_root"
-
-  # unique
-
-  EXAMPLE_PACKAGE_DIR="$BATS_TMPDIR/example_package"
 }
 
 teardown() {
-  rm -r "$EXAMPLE_PACKAGE_DIR"
+  rm "$EXAMPLE_PACKAGE_DIR"/.node-version
+  rm "$EXAMPLE_PACKAGE_DIR"/package.json
   rm "$NODENV_ROOT"/versions/*
   rm -f "$NODENV_ROOT/version"
 }
 
-# cd_into_package nodeVersion [extraArgs]
-cd_into_package() {
-  mkdir -p "$EXAMPLE_PACKAGE_DIR"
+in_package_for_engine() {
   cd "$EXAMPLE_PACKAGE_DIR" || return 1
-  local version="$1"
   cat << JSON > package.json
 {
   "engines": {
-    "node": "$version"
+    "node": "$1"
   }
 }
 JSON
 }
 
 cd_into_babel_env_package() {
-  mkdir -p "$EXAMPLE_PACKAGE_DIR"
   cd "$EXAMPLE_PACKAGE_DIR" || return 1
   cat << JSON > package.json
 {
@@ -55,6 +51,6 @@ JSON
 
 with_installed_node_versions() {
   for v in "$@"; do
-    ln -fhs $BATS_TEST_DIRNAME/fixtures/node-x.y.z/ $NODENV_ROOT/versions/$v
+    ln -fhs "$BATS_TEST_DIRNAME/fixtures/node-x.y.z/" "$NODENV_ROOT/versions/$v"
   done
 }