Use fixture for nodenv root

We can have a single node version fixture.
And have the tests ship with a nodenv_root fixture.
This allows us to have the plugin under test be symlinked into our root
fixture, which requires less setup (no more env var munging) and is
faster than creating the test root from scratch.

Also with this root fixture, we can just symlink the single node fixture
into nodenv root's versions directory, to simulate any number of
installed nodes.

The only additional work, is that we now have to clean up the versions
directory and the global version, since the root fixture now persists
between tests.

Author: jasonkarns

test/fixtures/node-x.y.z/bin/node

@@ -0,0 +1 @@
+../../../..

test/fixtures/nodenv_root/plugins/nodenv-package-json-engine

@@ -3,7 +3,7 @@
 load test_helper
 
 @test 'Recognizes simple node version specified in package.json engines' {
-  create_version 4.2.1
+  with_installed_node_versions 4.2.1
   cd_into_package 4.2.1
 
   run nodenv version
@@ -13,24 +13,23 @@ load test_helper
 }
 
 @test 'Recognizes a semver range matching an installed version' {
-  create_version 4.2.1
+  with_installed_node_versions 4.2.1
   cd_into_package '>= 4.0.0'
 
   run nodenv version
   assert_success '4.2.1 (set by package-json-engine matching >= 4.0.0)'
 }
 
 @test 'Prefers the greatest installed version matching a range' {
-  create_version 4.0.0
-  create_version 4.2.1
+  with_installed_node_versions 4.0.0 4.2.1
   cd_into_package '^4.0.0'
 
   run nodenv version
   assert_success '4.2.1 (set by package-json-engine matching ^4.0.0)'
 }
 
 @test 'Ignores non-matching installed versions' {
-  create_version 0.12.7
+  with_installed_node_versions 0.12.7
   cd_into_package '>= 4.0.0'
 
   # For unknown reasons, nodenv-version succeeds when version-name fails,
@@ -46,8 +45,7 @@ load test_helper
 }
 
 @test 'Prefers nodenv-local over package.json' {
-  create_version 4.2.1
-  create_version 5.0.0
+  with_installed_node_versions 4.2.1 5.0.0
   cd_into_package 4.2.1
   nodenv local 5.0.0
 
@@ -56,7 +54,7 @@ load test_helper
 }
 
 @test 'Prefers nodenv-shell over package.json' {
-  create_version 5.0.0
+  with_installed_node_versions 5.0.0
   cd_into_package 4.2.1
   eval "$(nodenv sh-shell 5.0.0)"
 
@@ -65,8 +63,7 @@ load test_helper
 }
 
 @test 'Prefers package.json over nodenv-global' {
-  create_version 4.2.1
-  create_version 5.0.0
+  with_installed_node_versions 4.2.1 5.0.0
   cd_into_package 4.2.1
   nodenv global 5.0.0
 
@@ -75,8 +72,7 @@ load test_helper
 }
 
 @test 'Is not confused by nodenv-shell shadowing nodenv-global' {
-  create_version 4.2.1
-  create_version 5.0.0
+  with_installed_node_versions 4.2.1 5.0.0
   cd_into_package 4.2.1
   nodenv global 5.0.0
   eval "$(nodenv sh-shell 5.0.0)"
@@ -86,7 +82,7 @@ load test_helper
 }
 
 @test 'Does not match babel preset env settings' {
-  create_version 4.2.1
+  with_installed_node_versions 4.2.1
   cd_into_babel_env_package
   run nodenv version-name
   assert_success 'system'

test/nodenv-package-json-engine.bats

@@ -7,12 +7,10 @@ setup() {
   unset NODENV_VERSION
 
   local node_modules_bin=$BATS_TEST_DIRNAME/../node_modules/.bin
-  local plugin_bin=$BATS_TEST_DIRNAME/../bin
 
-  export PATH="$plugin_bin:$node_modules_bin:/usr/bin:/bin:/usr/sbin:/sbin"
+  export PATH="$node_modules_bin:/usr/bin:/bin:/usr/sbin:/sbin"
 
-  export NODENV_ROOT="$BATS_TMPDIR/nodenv_root"
-  export NODENV_HOOK_PATH="$BATS_TEST_DIRNAME/../etc/nodenv.d"
+  export NODENV_ROOT="$BATS_TEST_DIRNAME/fixtures/nodenv_root"
 
   # unique
 
@@ -21,7 +19,8 @@ setup() {
 
 teardown() {
   rm -r "$EXAMPLE_PACKAGE_DIR"
-  rm -r "$NODENV_ROOT"
+  rm "$NODENV_ROOT"/versions/*
+  rm -f "$NODENV_ROOT/version"
 }
 
 # cd_into_package nodeVersion [extraArgs]
@@ -54,9 +53,8 @@ cd_into_babel_env_package() {
 JSON
 }
 
-# Creates fake version directory
-create_version() {
-  d="$NODENV_ROOT/versions/$1/bin"
-  mkdir -p "$d"
-  ln -s /bin/echo "$d/node"
+with_installed_node_versions() {
+  for v in "$@"; do
+    ln -fhs $BATS_TEST_DIRNAME/fixtures/node-x.y.z/ $NODENV_ROOT/versions/$v
+  done
 }