Keep set of installed versions in fixture

No need to repeatedly symlink the same set of versions.
Instead, let's just add them to the fixture and remove the helper code
for creating/destroying them.

Author: jasonkarns

test/fixtures/nodenv_root/versions/4.0.0

@@ -0,0 +1 @@
+/Users/jasonkarns/Projects/nodenv/nodenv-package-json-engine/test/fixtures/node-x.y.z/

test/fixtures/nodenv_root/versions/4.2.1

@@ -0,0 +1 @@
+/Users/jasonkarns/Projects/nodenv/nodenv-package-json-engine/test/fixtures/node-x.y.z/

test/fixtures/nodenv_root/versions/5.0.0

@@ -0,0 +1 @@
+/Users/jasonkarns/Projects/nodenv/nodenv-package-json-engine/test/fixtures/node-x.y.z/

test/nodenv-package-json-engine.bats

@@ -3,39 +3,26 @@
 load test_helper
 
 @test 'Recognizes simple node version specified in package.json engines' {
-  with_installed_node_versions 4.2.1
   in_package_for_engine 4.2.1
 
   run nodenv version
   assert_success '4.2.1 (set by package-json-engine matching 4.2.1)'
-  run nodenv which node
-  assert_success "${NODENV_ROOT}/versions/4.2.1/bin/node"
-}
-
-@test 'Recognizes a semver range matching an installed version' {
-  with_installed_node_versions 4.2.1
-  in_package_for_engine '>= 4.0.0'
-
-  run nodenv version
-  assert_success '4.2.1 (set by package-json-engine matching >= 4.0.0)'
 }
 
 @test 'Prefers the greatest installed version matching a range' {
-  with_installed_node_versions 4.0.0 4.2.1
   in_package_for_engine '^4.0.0'
 
   run nodenv version
   assert_success '4.2.1 (set by package-json-engine matching ^4.0.0)'
 }
 
 @test 'Ignores non-matching installed versions' {
-  with_installed_node_versions 0.12.7
-  in_package_for_engine '>= 4.0.0'
+  in_package_for_engine '^1.0.0'
 
   # For unknown reasons, nodenv-version succeeds when version-name fails,
   # so we're testing version-name directly
   run nodenv version-name
-  assert [ "$output" = "package-json-engine: no version satisfying \`>= 4.0.0' installed" ]
+  assert [ "$output" = "package-json-engine: no version satisfying \`^1.0.0' installed" ]
   assert [ "$status" -eq 1 ]
 
   # `which` should fail similarly
@@ -45,7 +32,6 @@ load test_helper
 }
 
 @test 'Prefers nodenv-local over package.json' {
-  with_installed_node_versions 4.2.1 5.0.0
   in_package_for_engine 4.2.1
   nodenv local 5.0.0
 
@@ -54,7 +40,6 @@ load test_helper
 }
 
 @test 'Prefers nodenv-shell over package.json' {
-  with_installed_node_versions 5.0.0
   in_package_for_engine 4.2.1
   eval "$(nodenv sh-shell 5.0.0)"
 
@@ -63,7 +48,6 @@ load test_helper
 }
 
 @test 'Prefers package.json over nodenv-global' {
-  with_installed_node_versions 4.2.1 5.0.0
   in_package_for_engine 4.2.1
   nodenv global 5.0.0
 
@@ -72,7 +56,6 @@ load test_helper
 }
 
 @test 'Is not confused by nodenv-shell shadowing nodenv-global' {
-  with_installed_node_versions 4.2.1 5.0.0
   in_package_for_engine 4.2.1
   nodenv global 5.0.0
   eval "$(nodenv sh-shell 5.0.0)"
@@ -82,7 +65,6 @@ load test_helper
 }
 
 @test 'Does not match babel preset env settings' {
-  with_installed_node_versions 4.2.1
   cd_into_babel_env_package
   run nodenv version-name
   assert_success 'system'

test/test_helper.bash

@@ -17,9 +17,8 @@ setup() {
 }
 
 teardown() {
-  rm "$EXAMPLE_PACKAGE_DIR"/.node-version
-  rm "$EXAMPLE_PACKAGE_DIR"/package.json
-  rm "$NODENV_ROOT"/versions/*
+  rm -f "$EXAMPLE_PACKAGE_DIR"/.node-version
+  rm -f "$EXAMPLE_PACKAGE_DIR"/package.json
   rm -f "$NODENV_ROOT/version"
 }
 
@@ -48,9 +47,3 @@ cd_into_babel_env_package() {
 }
 JSON
 }
-
-with_installed_node_versions() {
-  for v in "$@"; do
-    ln -fhs "$BATS_TEST_DIRNAME/fixtures/node-x.y.z/" "$NODENV_ROOT/versions/$v"
-  done
-}