Skip to content

Conversation

@vicb
Copy link
Contributor

@vicb vicb commented Nov 4, 2025

Description

simplify the remote patterns config

ref: simplify the remote patterns config

Validation

Related Issues

#8304 (comment)

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

👆 format, test, and build fails on main

Copilot AI review requested due to automatic review settings November 4, 2025 12:59
@vicb vicb requested a review from a team as a code owner November 4, 2025 12:59
@vercel
Copy link

vercel bot commented Nov 4, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Nov 4, 2025 1:00pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the remotePatterns configuration in the Next.js config by replacing verbose object literals with URL constructors for defining allowed remote image sources.

  • Replaces explicit object patterns ({protocol, hostname, port, pathname}) with new URL() constructor calls
  • Reduces configuration verbosity from 5 multi-line objects to 5 single-line URL constructor calls

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MattIPv4 MattIPv4 added the github_actions:pull-request Trigger Pull Request Checks label Nov 4, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Nov 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟠 88 🟢 100 🟢 100 🔗
/en/about 🟢 100 🟢 93 🟢 100 🟠 88 🔗
/en/about/previous-releases 🟢 99 🟢 93 🟢 100 🟢 100 🔗
/en/download 🟢 98 🟢 96 🟢 100 🟢 100 🔗
/en/download/archive/current 🟢 100 🟢 100 🟢 100 🟢 100 🔗
/en/blog 🟢 99 🟢 100 🟢 96 🟢 100 🔗

@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.73%. Comparing base (9fbb9f6) to head (36d5cf0).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8325      +/-   ##
==========================================
+ Coverage   76.72%   76.73%   +0.01%     
==========================================
  Files         118      118              
  Lines        9805     9805              
  Branches      335      335              
==========================================
+ Hits         7523     7524       +1     
+ Misses       2280     2279       -1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avivkeller avivkeller added this pull request to the merge queue Nov 6, 2025
Merged via the queue into nodejs:main with commit e0c6c49 Nov 6, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants