chore(versioning): bump node to v24, pnpm to v10.20 #8289
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8289 +/- ##
==========================================
- Coverage 76.62% 75.39% -1.24%
==========================================
Files 117 106 -11
Lines 9751 8969 -782
Branches 328 308 -20
==========================================
- Hits 7472 6762 -710
+ Misses 2277 2205 -72
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the project's Node.js runtime from v22.14.0 to v24.11.0 and pnpm package manager from 10.13.1 to 10.20.0.
- Updates Node.js version to v24.11.0 across configuration files
- Upgrades pnpm to version 10.20.0
- Removes the manual npm reinstall step from the publish workflow since Node.js v24 comes with npm 11+ by default
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updates packageManager to pnpm@10.20.0 and devEngines to require Node.js >=v24.11.0 and pnpm 10.20.0 |
| .nvmrc | Changes Node version from v22.14.0 to v24 (major version only) |
| .github/workflows/publish-packages.yml | Removes npm reinstall step that was needed for OIDC support in Node.js v22 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
|
|
||
| catalog: | ||
| '@types/node': 22.18.6 | ||
| '@types/node': 24.9.2 |
There was a problem hiding this comment.
Why is this pinned to a specific version?
There was a problem hiding this comment.
24.9.2 is the latest type available from @types/node
There was a problem hiding this comment.
Why such a giant diff on this? A bunch of transient versions seem to have changed?
There was a problem hiding this comment.
pnpm re-generated the lockfile during the version bump, I can have it not do that if you'd like
There was a problem hiding this comment.
Yes, please, I don't think we should be bumping a bunch of dependencies at the same time.
|
👀 so Vercel doesn't appear to support 24.x yet: https://vercel.com/docs/functions/runtimes/node-js/node-js-versions I'm quite surprised the build didn't fail? Are we not setting |
We are on the root, but iirc we use |
|
I see, I think we want to set |
There was a problem hiding this comment.
I'd really prefer that we pin to a specific version.
There was a problem hiding this comment.
iiuc we only pinned to a specific version since we needed to be >= it. We support any v24.x, why do we need to pin to a specific one? (If we did, tho, I would assume it to be .11.0)
|
Blocked until Vercel supports v24. They currently do not have a target date, but expect it sometime soon. cc @styfle Can you update us once this is available? |
|
@avivkeller can you try setting |
This PR bumps our Node.js version to v24(.11.0), and our pnpm version to 10.20.
Ref: #8092