merge release 4.3.0 into master #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [mocha](https://github.com/mochajs/mocha) from 9.2.2 to 10.0.0. - [Release notes](https://github.com/mochajs/mocha/releases) - [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md) - [Commits](mochajs/mocha@v9.2.2...v10.0.0) --- updated-dependencies: - dependency-name: mocha dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [sinon](https://github.com/sinonjs/sinon) from 13.0.1 to 14.0.0. - [Release notes](https://github.com/sinonjs/sinon/releases) - [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md) - [Commits](sinonjs/sinon@v13.0.1...v14.0.0) --- updated-dependencies: - dependency-name: sinon dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…-14.0.0 build(deps-dev): bump sinon from 13.0.1 to 14.0.0
…-10.0.0 build(deps-dev): bump mocha from 9.2.2 to 10.0.0
Fixed order of checks in authorize-handler
* only allow parameters in body
…eChallengeMethod ar set
Merge pull request #161 from martinssonj/save-codechallenge-for-pkce
Co-authored-by: Jonathan Martinsson <jonathan.martinsson@gmail.com>
…unsupported code challenge method
Merge pull request #86 from node-oauth/feature-pkce Contributors: @martinssonj @jankapunkt @Uzlopak
release 4.3.0
Member
Author
|
In order to get our integration tests running for newer node versions (16/18) we will have to merge #107 but since this will be breaking for some users we will have to make a new major release for that. |
Member
Author
|
@Uzlopak @HappyZombies @jorenvandeweyer anyone has time for a review? |
jorenvandeweyer
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our CI for Node 16 and 18 for test release is somewhat broken 🤔