nixos/common: update KexAlgorithms selection #713
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit message:
IMO this should try to fail open: right now, new algorithms are forbidden by this configuration. This is also how I learned of this, because of some PQ insecure KexAlgo warnings that openSSH now emits.
Alternatively the
KexAlgorithmskey could be completely dropped but at this time this supposes a risk of breaking some users SSH as this would drop theDH-group{16,18}-sha512algorithmsNote: there is another section in the
darwin/common/openssh.nixfile, but I know nothing about Darwin nor how the system SSH daemon would load the resulting file with the rest of the configurationEdit: just force pushed a rebase on master