-
Notifications
You must be signed in to change notification settings - Fork 83
Use systemd credentials to provision secrets for attestation server #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
d638560 to
3c44211
Compare
|
Caused by https://github.com/danielfullmer/robotnix/blob/bdb085a460a83c79c50a00af72b961cb982d53dc/nixos/attestation-server/test.nix#L21 Although I think we'll delay merging this change until NixOS 21.05 is released, (luckily not too long). |
3c44211 to
63f6adf
Compare
I think this just happened because of
NixOS 21.05 is a hard requirement, because |
Makes sense. I was overthinking it and assuming that NixOS had some extra logic to ensure that publicly-readable secrets wouldn't end up in the |
63f6adf to
bd29779
Compare
|
I just ran the test on NixOS 21.05 but I get this weird failure: |
| "('emailLocal', '${if local then "1" else "0"}')" | ||
| ]; | ||
| in lib.optionals (passwordFile != null) [ | ||
| # Note the leading + on the first command. The passwordFile could be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this comment as well
I can reproduce that issue as well with 21.05. There's this issue, which looks related, as well a fix for it in systemd 248 (not in NixOS 21.05) |
bd29779 to
3fcf9cf
Compare
Fixes #80 properly.
Depends on systemd 247 in NixOS 21.05.