FIX: ANTs' utilities revision - bug fixes and add more operations to ants.ImageMath
#3236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These added operations are necessary for the antsBrainExtraction workflow we have in niworkflows (and hence niflows too).
Contributor
Author
|
For the |
oesteban
added a commit
to oesteban/niworkflows
that referenced
this pull request
Aug 12, 2020
this commit requires nipy/nipype#3236 to be merged.
Codecov Report
@@ Coverage Diff @@
## master #3236 +/- ##
==========================================
- Coverage 65.00% 64.96% -0.05%
==========================================
Files 302 302
Lines 39929 39929
Branches 5279 5279
==========================================
- Hits 25956 25939 -17
- Misses 12913 12925 +12
- Partials 1060 1065 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
oesteban
changed the title
ants.ImageMathants.ImageMath
oesteban
force-pushed
the
oesteban-patch-1
branch
from
6d59c93 to
db819a9
Compare
- Disable ``copy_header`` for the ``PadImage`` operation in ``ImageMath`` - Drop the CopyHeader mixin and update auto test of ResampleImageBySpacing
oesteban
force-pushed
the
oesteban-patch-1
branch
from
db819a9 to
e59aaa6
Compare
oesteban
added a commit
to oesteban/niworkflows
that referenced
this pull request
Aug 12, 2020
this commit requires nipy/nipype#3236 to be merged.
effigies
reviewed
Aug 12, 2020
Member
|
Looks reasonable. |
effigies
reviewed
Aug 13, 2020
Member
effigies
left a comment
effigies
left a comment
There was a problem hiding this comment.
Some alternative suggestions. I prefer RST plain text to Python comments. Added some context about what copy_header does.
oesteban
force-pushed
the
oesteban-patch-1
branch
from
1d95223 to
0fffcf7
Compare
oesteban
force-pushed
the
oesteban-patch-1
branch
from
0fffcf7 to
461bc5e
Compare
oesteban
added a commit
to oesteban/niworkflows
that referenced
this pull request
Aug 13, 2020
this commit requires nipy/nipype#3236 to be merged.
oesteban
added a commit
to oesteban/niworkflows
that referenced
this pull request
Aug 13, 2020
this commit requires nipy/nipype#3236 to be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These revisions are necessary for the antsBrainExtraction workflow we have in niworkflows (and hence niflows too):
ImageMathoperations, overwriting the behavior ofcopy_headerif the operation isPadImage(see comment below).copy_headerofResampleImageBySpacingas the original affine is not valid anymore in the output