Skip to content

Conversation

@effigies
Copy link
Member

Summary

Addresses #3157 in maint/1.3.x.

List of changes proposed in this PR (pull-request)

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #3158 into maint/1.3.x will increase coverage by 0.91%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           maint/1.3.x    #3158      +/-   ##
===============================================
+ Coverage        67.25%   68.17%   +0.91%     
===============================================
  Files              296      297       +1     
  Lines            39804    39825      +21     
  Branches          5208     5218      +10     
===============================================
+ Hits             26772    27149     +377     
+ Misses           12316    11966     -350     
+ Partials           716      710       -6
Flag Coverage Δ
#smoketests 51.76% <100%> (+1.1%) ⬆️
#unittests 65.41% <100%> (+0.87%) ⬆️
Impacted Files Coverage Δ
nipype/interfaces/base/traits_extension.py 95.87% <100%> (+0.06%) ⬆️
nipype/testing/__init__.py 88.88% <0%> (ø)
nipype/interfaces/base/core.py 87.11% <0%> (+0.19%) ⬆️
nipype/interfaces/spm/preprocess.py 57.03% <0%> (+0.32%) ⬆️
nipype/pipeline/engine/workflows.py 76.93% <0%> (+0.33%) ⬆️
nipype/utils/subprocess.py 94.02% <0%> (+0.74%) ⬆️
nipype/interfaces/freesurfer/preprocess.py 66.11% <0%> (+0.98%) ⬆️
nipype/interfaces/fsl/base.py 86.66% <0%> (+1.11%) ⬆️
nipype/interfaces/freesurfer/model.py 64.25% <0%> (+1.12%) ⬆️
nipype/utils/filemanip.py 78.9% <0%> (+1.12%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c4f9b7...89d0da5. Read the comment docs.

@effigies effigies merged commit dc4eee4 into nipy:maint/1.3.x Jan 30, 2020
@effigies effigies deleted the fix/traits_6_import branch January 30, 2020 21:37
@effigies effigies added this to the 1.4.2 milestone Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant