Aidan/clear has field type aliases #696
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for typing field manipulation functions Signed-off-by: Aidan Jensen <aidandj.github@gmail.com>
Signed-off-by: Aidan Jensen <aidandj.github@gmail.com>
aidandj
commented
Nov 28, 2025
aidandj
commented
Nov 28, 2025
aidandj
force-pushed
the
aidan/clear-has-field-type-aliases
branch
from
1ebaa01 to
411eb53
Compare
Add WhichOneofArgType and WhichOneofReturnType aliases Signed-off-by: Aidan Jensen <aidandj.github@gmail.com>
aidandj
force-pushed
the
aidan/clear-has-field-type-aliases
branch
from
411eb53 to
b5dcfc2
Compare
Collaborator
Author
|
WhichOneof type aliases ended up being simple. At first I was just going to number them, but then I realized that may not be static if new oneofs were added, unless i ordered them by field number. So I just appended the oneof name to the end of the field. All proto message names are valid python identifiers, so this was the safer, and more descriptive way. The name isn't always the prettiest, but its unique and descriptive. |
aidandj
commented
Nov 28, 2025
aidandj
commented
Nov 28, 2025
nipunn1313
approved these changes
Dec 3, 2025
Owner
nipunn1313
left a comment
nipunn1313
left a comment
There was a problem hiding this comment.
oof complex impl, but seems good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've occasionally found myself wanting type aliases for these literals so you can properly type fields that call Clear or HasFields.
I'd like to do
Oneofas well, because then you can separate outOneofpattern match chains into separate functions.Oneofhas the type overloads though, and the aliases are slightly more complicated. That will be another PR.